Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
CC:
Mads Ager (chromium), darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, cmumford, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), haraken, hongchan, jbroman, jchaffraix+rendering, jfernandez, jsbell+idb_chromium.org, Justin Novosad, kinuko+watch, kouhei+heap_chromium.org, leviw+renderwatch, Mikhail, oilpan-reviews, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, Manuel Rego, rjwright, rwlbuis, Raymond Toy, Stephen Chennney, shans, sof, svillar, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ASSERT_WITH_MESSAGE family. This CL removes: - ASSERT_WITH_MESSAGE - ASSERT_WITH_MESSAGE_UNUSED - RELEASE_ASSERT_WITH_MESSAGE - WTFReportAssertionFailureWithMessage() DCHECK / CHECK has ability to specify messages. This CL also add stream printer for LayoutUnit. It's necessary to use LayoutUnit in DCHECK macro. BUG=596760 Committed: https://crrev.com/f32b99d3b806b471ccb249d14c1c41070f39da02 Cr-Commit-Position: refs/heads/master@{#382775}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -77 lines) Patch
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 2 chunks +10 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 chunk +1 line, -1 line 2 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/mac/BlockExceptions.mm View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 3 chunks +0 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tkent
yutak@, would you review this please?
4 years, 9 months ago (2016-03-23 02:02:21 UTC) #3
haraken
LGTM https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right): https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp#newcode269 third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:269: #if DCHECK_IS_ON() I'm just curious but do you ...
4 years, 9 months ago (2016-03-23 02:10:01 UTC) #5
tkent
https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp File third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp (right): https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp#newcode269 third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp:269: #if DCHECK_IS_ON() On 2016/03/23 at 02:10:01, haraken wrote: > ...
4 years, 9 months ago (2016-03-23 02:20:52 UTC) #6
tkent
https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp File third_party/WebKit/Source/modules/webaudio/AudioNode.cpp (left): https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp#oldcode514 third_party/WebKit/Source/modules/webaudio/AudioNode.cpp:514: ASSERT_WITH_MESSAGE(1, "numberOfOutputChannels() not valid for node type %d", getNodeType()); ...
4 years, 9 months ago (2016-03-23 02:23:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826733002/1
4 years, 9 months ago (2016-03-23 02:34:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 02:40:04 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f32b99d3b806b471ccb249d14c1c41070f39da02 Cr-Commit-Position: refs/heads/master@{#382775}
4 years, 9 months ago (2016-03-23 02:41:20 UTC) #13
Raymond Toy
4 years, 9 months ago (2016-03-23 19:31:52 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/AudioNode.cpp (left):

https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/AudioNode.cpp:514:
ASSERT_WITH_MESSAGE(1, "numberOfOutputChannels() not valid for node type %d",
getNodeType());
On 2016/03/23 02:23:53, tkent wrote:
> rtoy,
> The original code looks weird.  ASSERT(1) means no assertion failure.
> 

Yeah, that's wrong.  This CL has landed so I'll fix it in a different CL.

Powered by Google App Engine
This is Rietveld 408576698