third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp - Issue 1826733002: Remove ASSERT_WITH_MESSAGE family.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTableSection.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

index 503b63b0d68d4df0fab7dd78dabe9acba8e76693..0c88bf3a50550254b9dc63db557d1a11d1937378 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

@@ -452,7 +452,7 @@ DispatchEventResult IDBRequest::dispatchEventInternal(PassRefPtrWillBeRawPtr<Eve

}

// FIXME: When we allow custom event dispatching, this will probably need to change.

- ASSERT_WITH_MESSAGE(event->type() == EventTypeNames::success || event->type() == EventTypeNames::error || event->type() == EventTypeNames::blocked || event->type() == EventTypeNames::upgradeneeded, "event type was %s", event->type().utf8().data());

+ DCHECK(event->type() == EventTypeNames::success || event->type() == EventTypeNames::error || event->type() == EventTypeNames::blocked || event->type() == EventTypeNames::upgradeneeded) << "event type was " << event->type();

const bool setTransactionActive = m_transaction && (event->type() == EventTypeNames::success || event->type() == EventTypeNames::upgradeneeded || (event->type() == EventTypeNames::error && !m_requestAborted));

if (setTransactionActive)

@@ -517,7 +517,7 @@ void IDBRequest::enqueueEvent(PassRefPtrWillBeRawPtr<Event> event)

if (m_contextStopped || !getExecutionContext())

return;

- ASSERT_WITH_MESSAGE(m_readyState == PENDING || m_didFireUpgradeNeededEvent, "When queueing event %s, m_readyState was %d", event->type().utf8().data(), m_readyState);

+ DCHECK(m_readyState == PENDING || m_didFireUpgradeNeededEvent) << "When queueing event " << event->type() << ", m_readyState was " << m_readyState;

EventQueue* eventQueue = getExecutionContext()->getEventQueue();

event->setTarget(this);