third_party/WebKit/Source/platform/Timer.cpp - Issue 1826733002: Remove ASSERT_WITH_MESSAGE family.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/Timer.cpp

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioNode.cpp ('K') | « third_party/WebKit/Source/platform/Timer.h ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/Timer.cpp

diff --git a/third_party/WebKit/Source/platform/Timer.cpp b/third_party/WebKit/Source/platform/Timer.cpp

index b985f3811dc484b5779b5eee135a505d21c904f8..3c2e932ff9aca1f074b548ef7b4e5e9f3c846b05 100644

--- a/third_party/WebKit/Source/platform/Timer.cpp

+++ b/third_party/WebKit/Source/platform/Timer.cpp

@@ -117,7 +117,9 @@ void TimerBase::runInternal()

return;

TRACE_EVENT0("blink", "TimerBase::run");

- ASSERT_WITH_MESSAGE(m_thread == currentThread(), "Timer posted by %s %s was run on a different thread", m_location.functionName(), m_location.fileName());

+#if DCHECK_IS_ON()

+ DCHECK_EQ(m_thread, currentThread()) << "Timer posted by " << m_location.functionName() << " " << m_location.fileName() << " was run on a different thread";

+#endif

TRACE_EVENT_SET_SAMPLING_STATE("blink", "BlinkInternal");

if (m_repeatInterval) {