third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 1826733002: Remove ASSERT_WITH_MESSAGE family.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 845a3f092c3c62ef4647eb9c56f39931f049ea20..3e6d595f16a00cd870f3b561539feee56b9a7102 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -116,7 +116,7 @@ void StyleBuilder::applyProperty(CSSPropertyID id, StyleResolverState& state, CS

return;

}

- ASSERT_WITH_MESSAGE(!isShorthandProperty(id), "Shorthand property id = %d wasn't expanded at parsing time", id);

+ DCHECK(!isShorthandProperty(id)) << "Shorthand property id = " << id << " wasn't expanded at parsing time";

bool isInherit = state.parentNode() && value->isInheritedValue();

bool isInitial = value->isInitialValue() || (!state.parentNode() && value->isInheritedValue());