Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
index 808662b9cbef0e653b676dc0d1f7641e1a6eb149..e666a35032bc023a8a4dc898e4a561e614f1a7f0 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
@@ -511,7 +511,7 @@ unsigned AudioHandler::numberOfOutputChannels() const
// This should only be called for ScriptProcessorNodes which are the only nodes where you can
// have an output with 0 channels. All other nodes have have at least one output channel, so
// there's no reason other nodes should ever call this function.
- ASSERT_WITH_MESSAGE(1, "numberOfOutputChannels() not valid for node type %d", getNodeType());
tkent 2016/03/23 02:23:53 rtoy, The original code looks weird. ASSERT(1) me
Raymond Toy 2016/03/23 19:31:52 Yeah, that's wrong. This CL has landed so I'll fi
+ DCHECK(1) << "numberOfOutputChannels() not valid for node type " << getNodeType();
return 1;
}
// ----------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698