third_party/WebKit/Source/platform/mac/BlockExceptions.mm - Issue 1826733002: Remove ASSERT_WITH_MESSAGE family.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mac/BlockExceptions.mm

Issue 1826733002: Remove ASSERT_WITH_MESSAGE family. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mac/BlockExceptions.mm

diff --git a/third_party/WebKit/Source/platform/mac/BlockExceptions.mm b/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

index ccecee34e23122b2c94365320a1719ac60351c79..e823c3a8892aeb380f6b8d01a048ab6428812f3c 100644

--- a/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

+++ b/third_party/WebKit/Source/platform/mac/BlockExceptions.mm

@@ -29,8 +29,11 @@

void ReportBlockedObjCException(NSException *exception)

{

-#if ENABLE(ASSERT)

- ASSERT_WITH_MESSAGE(0, "Uncaught exception - %s", [[exception description] UTF8String]);

+#if DCHECK_IS_ON()

+ NOTREACHED() << "Uncaught exception - " << [[exception description] UTF8String];

+ // This function is marked as NO_RETURN_DUE_TO_ASSERT, but NOTREACHED() and

+ // DCHECK(false) are not recognized as NO_RETURN.

+ CRASH();

#else

NSLog(@"*** WebKit discarding exception: <%@> %@", [exception name], [exception reason]);

#endif