Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs

Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs (patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811/steps/compile/logs/stdio

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
>
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
>
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
>
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
>
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
>
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
>
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@chromium.org,danakj@chromium.org,fmalita@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077
Committed: https://crrev.com/12ebe1b82f24c532bb6695c1fb2a979dfccb4d79
Cr-Commit-Position: refs/heads/master@{#381575}

[fgorski, 2016-03-16 23:11:38]

Created Revert of Add sk_sp helpers and switch Blink SkShader clients to the new
APIs

[commit-bot: I haz the power, 2016-03-16 23:12:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814473003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814473003/1

[commit-bot: I haz the power, 2016-03-16 23:12:50]

Description was changed from

==========
Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs
(patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
> 
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
> 
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
> 
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
> 
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
> 
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
> 
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077
==========

to

==========
Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs
(patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
> 
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
> 
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
> 
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
> 
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
> 
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
> 
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077
==========

[commit-bot: I haz the power, 2016-03-16 23:12:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-16 23:15:48]

Description was changed from

==========
Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs
(patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
> 
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
> 
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
> 
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
> 
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
> 
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
> 
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077
==========

to

==========
Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs
(patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ )

Reason for revert:
Suspecting this patch to have caused the compilation failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp...

Original issue's description:
> Add sk_sp helpers and switch Blink SkShader clients to the new APIs
>
> Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp
> interoperability:
>
>  * adoptRef(sk_sp<T>)       - for adopting sk_sps rvals into PassRevPtr
>                               (when transferring ownership from Skia->Blink)
>  * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp
>                               (when transferring ownership from Blink->Skia)
>
> Update clients to use the new Skia shader factories ("makers" vs. prev
> "creators"), and sk_sp-based setters.
>
> A tangential change: deconstify SkPicture fields/args to align with the new
> Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now
> expects non-const SkPicture args).
>
> BUG=skia:5077
> R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org
>
> Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571
> Cr-Commit-Position: refs/heads/master@{#381563}

TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@ch...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077

Committed: https://crrev.com/12ebe1b82f24c532bb6695c1fb2a979dfccb4d79
Cr-Commit-Position: refs/heads/master@{#381575}
==========

[commit-bot: I haz the power, 2016-03-16 23:15:50]

Patchset 1 (id:??) landed as
https://crrev.com/12ebe1b82f24c532bb6695c1fb2a979dfccb4d79
Cr-Commit-Position: refs/heads/master@{#381575}