Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.h

Issue 1814473003: Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 3 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
4 * Copyright 2014 The Chromium Authors. All rights reserved. 4 * Copyright 2014 The Chromium Authors. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 void removeAllClientsFromCache(bool markForInvalidation = true) override; 47 void removeAllClientsFromCache(bool markForInvalidation = true) override;
48 void removeClientFromCache(LayoutObject*, bool markForInvalidation = true) o verride; 48 void removeClientFromCache(LayoutObject*, bool markForInvalidation = true) o verride;
49 49
50 SVGPaintServer preparePaintServer(const LayoutObject&) override; 50 SVGPaintServer preparePaintServer(const LayoutObject&) override;
51 51
52 static const LayoutSVGResourceType s_resourceType = PatternResourceType; 52 static const LayoutSVGResourceType s_resourceType = PatternResourceType;
53 LayoutSVGResourceType resourceType() const override { return s_resourceType; } 53 LayoutSVGResourceType resourceType() const override { return s_resourceType; }
54 54
55 private: 55 private:
56 PassOwnPtr<PatternData> buildPatternData(const LayoutObject&); 56 PassOwnPtr<PatternData> buildPatternData(const LayoutObject&);
57 PassRefPtr<SkPicture> asPicture(const FloatRect& tile, const AffineTransform &) const; 57 PassRefPtr<const SkPicture> asPicture(const FloatRect& tile, const AffineTra nsform&) const;
58 PatternData* patternForLayoutObject(const LayoutObject&); 58 PatternData* patternForLayoutObject(const LayoutObject&);
59 59
60 const LayoutSVGResourceContainer* resolveContentElement() const; 60 const LayoutSVGResourceContainer* resolveContentElement() const;
61 61
62 bool m_shouldCollectPatternAttributes : 1; 62 bool m_shouldCollectPatternAttributes : 1;
63 #if ENABLE(OILPAN) 63 #if ENABLE(OILPAN)
64 Persistent<PatternAttributesWrapper> m_attributesWrapper; 64 Persistent<PatternAttributesWrapper> m_attributesWrapper;
65 65
66 PatternAttributes& mutableAttributes() { return m_attributesWrapper->attribu tes(); } 66 PatternAttributes& mutableAttributes() { return m_attributesWrapper->attribu tes(); }
67 const PatternAttributes& attributes() const { return m_attributesWrapper->at tributes(); } 67 const PatternAttributes& attributes() const { return m_attributesWrapper->at tributes(); }
68 #else 68 #else
69 PatternAttributes m_attributes; 69 PatternAttributes m_attributes;
70 70
71 PatternAttributes& mutableAttributes() { return m_attributes; } 71 PatternAttributes& mutableAttributes() { return m_attributes; }
72 const PatternAttributes& attributes() const { return m_attributes; } 72 const PatternAttributes& attributes() const { return m_attributes; }
73 #endif 73 #endif
74 74
75 // FIXME: we can almost do away with this per-object map, but not quite: the tile size can be 75 // FIXME: we can almost do away with this per-object map, but not quite: the tile size can be
76 // relative to the client bounding box, and it gets captured in the cached P attern shader. 76 // relative to the client bounding box, and it gets captured in the cached P attern shader.
77 // Hence, we need one Pattern shader per client. The display list OTOH is th e same => we 77 // Hence, we need one Pattern shader per client. The display list OTOH is th e same => we
78 // should be able to cache a single display list per LayoutSVGResourcePatter n + one 78 // should be able to cache a single display list per LayoutSVGResourcePatter n + one
79 // Pattern(shader) for each client -- this would avoid re-recording when mul tiple clients 79 // Pattern(shader) for each client -- this would avoid re-recording when mul tiple clients
80 // share the same pattern. 80 // share the same pattern.
81 HashMap<const LayoutObject*, OwnPtr<PatternData>> m_patternMap; 81 HashMap<const LayoutObject*, OwnPtr<PatternData>> m_patternMap;
82 }; 82 };
83 83
84 } // namespace blink 84 } // namespace blink
85 85
86 #endif 86 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698