Make the debug interface a GrGLTestInterface subclass.

Make the debug interface a GrGLTestInterface subclass.

The debug interface subsumes the GrDebugGL singleton which allows multiple instances.

Fixes a few issues that existed before this CL (pack alignment wasn't tracked or respected, and we weren't initializing a texture id to 0 in one GM). Apparently this is not currently run on the bots.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1812323002

Committed: https://skia.googlesource.com/skia/+/3c481001b16288f604a5279bcb4bf46c5dd2b703

[bsalomon, 2016-03-18 21:33:21]

Description was changed from

==========
Make the debug interface a GrGLTestInterface subclass.

The debug interface subsumes the GrDebugGL singleton which allows multiple
instances.

Fixes a few issues that existed before this CL (pack alignment wasn't tracked or
respected, and we weren't initializing a texture id to 0 in one GM). Apparently
this is not currently run on the bots.


BUG=skia:
==========

to

==========
Make the debug interface a GrGLTestInterface subclass.

The debug interface subsumes the GrDebugGL singleton which allows multiple
instances.

Fixes a few issues that existed before this CL (pack alignment wasn't tracked or
respected, and we weren't initializing a texture id to 0 in one GM). Apparently
this is not currently run on the bots.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-18 21:36:19]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-03-18 21:36:19]

This is a whole lot of copy pasta, search and replace, and some manual cleanup.

Also, it isn't currently doesn't run on the bots. On my linux machine it passes
DM with this CL (but not without).

[robertphillips, 2016-03-21 14:52:40]

rs lgtm

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
File src/gpu/gl/debug/GrGLCreateDebugInterface.cpp (right):

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:26: // Helper macro to make
creating an object (where you need to get back a derived
Can this all go on one line ?

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:31: // Helper macro to make
creating an object (where you need to get back a derived
same here

[bsalomon, 2016-03-21 15:31:34]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-21 15:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1812323002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-03-21 15:31:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812323002/20001

[commit-bot: I haz the power, 2016-03-21 15:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 15:33:35]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[bsalomon, 2016-03-21 15:42:49]

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
File src/gpu/gl/debug/GrGLCreateDebugInterface.cpp (right):

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:26: // Helper macro to make
creating an object (where you need to get back a derived
On 2016/03/21 14:52:40, robertphillips wrote:
> Can this all go on one line ?

Done.

https://codereview.chromium.org/1812323002/diff/1/src/gpu/gl/debug/GrGLCreate...
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:31: // Helper macro to make
creating an object (where you need to get back a derived
On 2016/03/21 14:52:40, robertphillips wrote:
> same here

Done.

[bsalomon, 2016-03-21 15:49:29]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-21 15:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1812323002/#ps40001
(title: "remove unused member")

[commit-bot: I haz the power, 2016-03-21 15:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812323002/40001

[commit-bot: I haz the power, 2016-03-21 16:04:28]

Description was changed from

==========
Make the debug interface a GrGLTestInterface subclass.

The debug interface subsumes the GrDebugGL singleton which allows multiple
instances.

Fixes a few issues that existed before this CL (pack alignment wasn't tracked or
respected, and we weren't initializing a texture id to 0 in one GM). Apparently
this is not currently run on the bots.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make the debug interface a GrGLTestInterface subclass.

The debug interface subsumes the GrDebugGL singleton which allows multiple
instances.

Fixes a few issues that existed before this CL (pack alignment wasn't tracked or
respected, and we weren't initializing a texture id to 0 in one GM). Apparently
this is not currently run on the bots.


BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3c481001b16288f604a5279bcb4bf46c5dd2b703
==========

[commit-bot: I haz the power, 2016-03-21 16:04:30]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3c481001b16288f604a5279bcb4bf46c5dd2b703