[DevTools] Move evaluateOnCallFrame to native

[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on V8WindowCustom binding is used instead existing scope_extension argument. In consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Committed: https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b
Cr-Commit-Position: refs/heads/master@{#381834}

[kozy, 2016-03-17 07:28:08]

Dmitry, please take a look!

[kozy, 2016-03-17 07:41:32]

Patchset #1 (id:1) has been deleted

[kozy, 2016-03-17 07:49:14]

Patchset #1 (id:20001) has been deleted

[kozy, 2016-03-17 07:51:36]

Patchset #1 (id:40001) has been deleted

[kozy, 2016-03-17 08:23:58]

Patchset #1 (id:60001) has been deleted

[kozy, 2016-03-17 17:24:45]

Patchset #1 (id:80001) has been deleted

[dgozman, 2016-03-17 19:16:12]

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:286: static
bool installScopeExtensionIfNeeded(Frame* frame, v8::Local<v8::Name> name, const
AtomicString& nameString, const v8::PropertyCallbackInfo<v8::Value>& info)
namedPropertyFromDebuggerScopeExtension

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:286: static
bool installScopeExtensionIfNeeded(Frame* frame, v8::Local<v8::Name> name, const
AtomicString& nameString, const v8::PropertyCallbackInfo<v8::Value>& info)
Remove frame.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:297:
v8::Local<v8::Context> context = toV8Context(frame,
DOMWrapperWorld::current(isolate));
Revert.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:247:
*errorString = "Internal error";
wrapValue takes care of errorString.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:114:
v8::MaybeLocal<v8::Object> scopeExtensionByName(ErrorString*, const String16&
name);
Make two methods here.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:193: ,
m_globals(v8::Array::New(injectedScript->isolate()))
Let's not create array when we don't need it.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:223:
bool success = m_globals->Get(m_context, i).ToLocal(&global);
Let's use vector.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:66:
class InjectScopeExtensionByName {
ScopedGlobalObjectExtension

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:69:
InjectScopeExtensionByName(ErrorString*, InjectedScript*, bool injectToAll,
const String16& name);
// Pass nullptr to affect all contexts which have access.
ScopedGlobalObjectExtension(v8::Local<v8::Context> current, InjectedScript*
affected, v8::MaybeLocal<v8::Value> extension);

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:74: void
setOnGlobal(v8::Local<v8::Object> global, v8::Local<v8::Object> scopeExtension);
scopeExtension -> extension

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp:194:
v8::MaybeLocal<v8::Value>
JavaScriptCallFrame::evaluateWithExceptionDetails(v8::Local<v8::Value>
expression)
Rename to evaluate.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp:202:
return evalFunction->Call(m_isolate->GetCurrentContext(), callFrame,
WTF_ARRAY_LENGTH(argv), argv);
1, &expression

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:723: if
(!injectedScript->wrapObjectProperty(errorString, detailsObject,
toV8String(m_isolate, "function"), groupName, false, true))
true -> false

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:949:
bool success =
javaScriptCallFrame->evaluateWithExceptionDetails(toV8String(injectedScript->isolate(),
expression)).ToLocal(&resultValue);
Let's pass Maybe further and forget about ToLocal here.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:952:
injectedScript = m_injectedScriptManager->findInjectedScript(errorString,
remoteId.get());
// InjectedScript may be gone after any evaluate call - find it again.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:956:
V8RuntimeAgentImpl::wrapEvaluateResult(errorString,
Let's make this an instance method on InjectedScript.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1048:
OwnPtr<RemoteObject> promiseObject = injectedScript->wrapObject(errorString,
value, objectGroup.fromMaybe(""));
Revert.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:308:
injectedScript =
m_injectedScriptManager->findInjectedScript(executionContextId);
Same comment here.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:314:
OwnPtr<RemoteObject> resultObject = injectedScript->wrapObject(errorString,
value, objectGroup.fromMaybe(""));
Just return.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:475:
*result = remoteObject.release();
Move after error checking.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:477: if
(!exceptionDetailsObject) {
It always returns something.

[kozy, 2016-03-17 20:48:57]

All done!

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:286: static
bool installScopeExtensionIfNeeded(Frame* frame, v8::Local<v8::Name> name, const
AtomicString& nameString, const v8::PropertyCallbackInfo<v8::Value>& info)
On 2016/03/17 19:16:11, dgozman wrote:
> namedPropertyFromDebuggerScopeExtension

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:286: static
bool installScopeExtensionIfNeeded(Frame* frame, v8::Local<v8::Name> name, const
AtomicString& nameString, const v8::PropertyCallbackInfo<v8::Value>& info)
On 2016/03/17 19:16:11, dgozman wrote:
> namedPropertyFromDebuggerScopeExtension

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp:297:
v8::Local<v8::Context> context = toV8Context(frame,
DOMWrapperWorld::current(isolate));
On 2016/03/17 19:16:11, dgozman wrote:
> Revert.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:247:
*errorString = "Internal error";
On 2016/03/17 19:16:11, dgozman wrote:
> wrapValue takes care of errorString.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:114:
v8::MaybeLocal<v8::Object> scopeExtensionByName(ErrorString*, const String16&
name);
On 2016/03/17 19:16:11, dgozman wrote:
> Make two methods here.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:193: ,
m_globals(v8::Array::New(injectedScript->isolate()))
On 2016/03/17 19:16:11, dgozman wrote:
> Let's not create array when we don't need it.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:223:
bool success = m_globals->Get(m_context, i).ToLocal(&global);
On 2016/03/17 19:16:11, dgozman wrote:
> Let's use vector.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:66:
class InjectScopeExtensionByName {
On 2016/03/17 19:16:12, dgozman wrote:
> ScopedGlobalObjectExtension

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:69:
InjectScopeExtensionByName(ErrorString*, InjectedScript*, bool injectToAll,
const String16& name);
On 2016/03/17 19:16:12, dgozman wrote:
> // Pass nullptr to affect all contexts which have access.
> ScopedGlobalObjectExtension(v8::Local<v8::Context> current, InjectedScript*
> affected, v8::MaybeLocal<v8::Value> extension);

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h:74: void
setOnGlobal(v8::Local<v8::Object> global, v8::Local<v8::Object> scopeExtension);
On 2016/03/17 19:16:12, dgozman wrote:
> scopeExtension -> extension

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp:194:
v8::MaybeLocal<v8::Value>
JavaScriptCallFrame::evaluateWithExceptionDetails(v8::Local<v8::Value>
expression)
On 2016/03/17 19:16:12, dgozman wrote:
> Rename to evaluate.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp:202:
return evalFunction->Call(m_isolate->GetCurrentContext(), callFrame,
WTF_ARRAY_LENGTH(argv), argv);
On 2016/03/17 19:16:12, dgozman wrote:
> 1, &expression

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:723: if
(!injectedScript->wrapObjectProperty(errorString, detailsObject,
toV8String(m_isolate, "function"), groupName, false, true))
On 2016/03/17 19:16:12, dgozman wrote:
> true -> false

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:949:
bool success =
javaScriptCallFrame->evaluateWithExceptionDetails(toV8String(injectedScript->isolate(),
expression)).ToLocal(&resultValue);
On 2016/03/17 19:16:12, dgozman wrote:
> Let's pass Maybe further and forget about ToLocal here.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:952:
injectedScript = m_injectedScriptManager->findInjectedScript(errorString,
remoteId.get());
On 2016/03/17 19:16:12, dgozman wrote:
> // InjectedScript may be gone after any evaluate call - find it again.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:956:
V8RuntimeAgentImpl::wrapEvaluateResult(errorString,
On 2016/03/17 19:16:12, dgozman wrote:
> Let's make this an instance method on InjectedScript.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1048:
OwnPtr<RemoteObject> promiseObject = injectedScript->wrapObject(errorString,
value, objectGroup.fromMaybe(""));
On 2016/03/17 19:16:12, dgozman wrote:
> Revert.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:308:
injectedScript =
m_injectedScriptManager->findInjectedScript(executionContextId);
On 2016/03/17 19:16:12, dgozman wrote:
> Same comment here.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:314:
OwnPtr<RemoteObject> resultObject = injectedScript->wrapObject(errorString,
value, objectGroup.fromMaybe(""));
On 2016/03/17 19:16:12, dgozman wrote:
> Just return.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:475:
*result = remoteObject.release();
On 2016/03/17 19:16:12, dgozman wrote:
> Move after error checking.

Done.

https://codereview.chromium.org/1811853002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:477: if
(!exceptionDetailsObject) {
On 2016/03/17 19:16:12, dgozman wrote:
> It always returns something.

Done.

[dgozman, 2016-03-17 20:56:12]

lgtm

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:108:
v8::TryCatch&,
const?

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:190: :
m_symbol(V8Debugger::scopeExtensionSymbol(current->isolate()))
Let's create this lazily.

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:942:
v8::Local<v8::Object> commandLineAPI;
Maybe

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:267:
v8::Local<v8::Object> commandLineAPI;
ditto

[kozy, 2016-03-17 21:05:22]

Thanks!
All done!

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h (right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h:108:
v8::TryCatch&,
On 2016/03/17 20:56:11, dgozman wrote:
> const?

Done.

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:190: :
m_symbol(V8Debugger::scopeExtensionSymbol(current->isolate()))
On 2016/03/17 20:56:11, dgozman wrote:
> Let's create this lazily.

Done.

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:942:
v8::Local<v8::Object> commandLineAPI;
On 2016/03/17 20:56:11, dgozman wrote:
> Maybe

Done.

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1811853002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:267:
v8::Local<v8::Object> commandLineAPI;
On 2016/03/17 20:56:12, dgozman wrote:
> ditto

Done.

[kozy, 2016-03-17 21:05:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-17 21:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1811853002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-03-17 21:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811853002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811853002/140001

[commit-bot: I haz the power, 2016-03-17 21:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:18:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kozy, 2016-03-17 21:20:01]

Description was changed from

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

[kozy, 2016-03-17 21:20:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:20:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811853002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811853002/140001

[commit-bot: I haz the power, 2016-03-17 23:29:21]

Description was changed from

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-03-17 23:29:23]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-03-17 23:30:33]

Description was changed from

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Move evaluateOnCallFrame to native

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on
V8WindowCustom binding is used instead existing scope_extension argument. In
consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Committed: https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b
Cr-Commit-Position: refs/heads/master@{#381834}
==========

[commit-bot: I haz the power, 2016-03-17 23:30:34]

Patchset 3 (id:??) landed as
https://crrev.com/fd40284be4bdc04e68401e25af2fbfb658a95a8b
Cr-Commit-Position: refs/heads/master@{#381834}