third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h - Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

index bd17be761c2968741dd271a1c934c6b7169c5bfd..c4e1f1ff004cc3a5abd754893b7a7b471f70f1ca 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

@@ -66,7 +66,7 @@ public:

bool isAtReturn() const;

v8::Local<v8::Value> returnValue() const;

- v8::Local<v8::Value> evaluateWithExceptionDetails(v8::Local<v8::Value> expression, v8::Local<v8::Value> scopeExtension);

+ v8::MaybeLocal<v8::Value> evaluate(v8::Local<v8::Value> expression);

v8::MaybeLocal<v8::Value> restart();

v8::MaybeLocal<v8::Value> setVariableValue(int scopeNumber, v8::Local<v8::Value> variableName, v8::Local<v8::Value> newValue);