Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
index 90ca442c40255cbbbabcc9c1b2385eacfa35ab9a..6096010615cdaecd1b83510ffed346384e8a1e66 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
@@ -326,21 +326,21 @@ void V8InjectedScriptHost::evaluateWithExceptionDetailsCallback(const v8::Functi
return;
}
- v8::Local<v8::Symbol> commandLineAPISymbolValue = V8Debugger::commandLineAPISymbol(isolate);
+ v8::Local<v8::Symbol> scopeExtensionSymbolValue = V8Debugger::scopeExtensionSymbol(isolate);
v8::Local<v8::Object> global = context->Global();
if (info.Length() >= 2 && info[1]->IsObject()) {
v8::Local<v8::Object> commandLineAPI = info[1]->ToObject(isolate);
- global->Set(commandLineAPISymbolValue, commandLineAPI);
+ global->Set(scopeExtensionSymbolValue, commandLineAPI);
}
v8::MaybeLocal<v8::Value> result = host->debugger()->runCompiledScript(context, script);
if (result.IsEmpty()) {
- global->Delete(context, commandLineAPISymbolValue);
+ global->Delete(context, scopeExtensionSymbolValue);
setExceptionAsReturnValue(info, wrappedResult, tryCatch);
return;
}
- global->Delete(context, commandLineAPISymbolValue);
+ global->Delete(context, scopeExtensionSymbolValue);
wrappedResult->Set(v8::String::NewFromUtf8(isolate, "result"), result.ToLocalChecked());
wrappedResult->Set(v8::String::NewFromUtf8(isolate, "exceptionDetails"), v8::Undefined(isolate));
v8SetReturnValue(info, wrappedResult);
@@ -509,9 +509,9 @@ void V8InjectedScriptHost::idToObjectGroupNameCallback(const v8::FunctionCallbac
info.GetReturnValue().Set(toV8String(info.GetIsolate(), groupName));
}
-v8::Local<v8::Symbol> V8Debugger::commandLineAPISymbol(v8::Isolate* isolate)
+v8::Local<v8::Symbol> V8Debugger::scopeExtensionSymbol(v8::Isolate* isolate)
{
- return v8::Symbol::ForApi(isolate, toV8StringInternalized(isolate, "commandLineAPI"));
+ return v8::Symbol::ForApi(isolate, toV8StringInternalized(isolate, "scopeExtension"));
}
bool V8Debugger::isCommandLineAPIMethod(const String16& name)

Powered by Google App Engine
This is Rietveld 408576698