third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp - Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

Issue 1811853002: [DevTools] Move evaluateOnCallFrame to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

index f132e8e71033cb9e7e478c2e7cbe351669f0f9ae..02dff5c03d699822e11bbb39a2c745a596c5edf3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp

@@ -93,12 +93,6 @@ void returnValueAttributeGetterCallback(v8::Local<v8::Name>, const v8::PropertyC

info.GetReturnValue().Set(impl->returnValue());

}

-void evaluateWithExceptionDetailsMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

- JavaScriptCallFrame* impl = V8JavaScriptCallFrame::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());

- info.GetReturnValue().Set(impl->evaluateWithExceptionDetails(info[0], info[1]));

void scopeTypeMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

{

JavaScriptCallFrame* impl = V8JavaScriptCallFrame::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());

@@ -160,7 +154,6 @@ const JavaScriptCallFrameWrapper::V8AttributeConfiguration V8JavaScriptCallFrame

};

const JavaScriptCallFrameWrapper::V8MethodConfiguration V8JavaScriptCallFrameMethods[] = {

- {"evaluateWithExceptionDetails", evaluateWithExceptionDetailsMethodCallback},

{"scopeType", scopeTypeMethodCallback},

{"scopeName", scopeNameMethodCallback},

{"scopeStartLocation", scopeStartLocationMethodCallback},