[DevTools] Move evaluate from InjectedScriptSource.js to native

[DevTools] Move evaluate from InjectedScriptSource.js to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3
Cr-Commit-Position: refs/heads/master@{#381902}

[kozy, 2016-03-17 17:48:56]

Dmitry, please take a look!

[pfeldman, 2016-03-17 21:24:22]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-03-17 21:24:22]

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt
(right):

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt:4:
VM:1 Uncaught SyntaxError: Invalid or unexpected token
Do we know why these changed?

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:136:
injectedScript = m_injectedScriptManager->findInjectedScript(errorString,
executionContextId.fromJust());
Is there a chance m_injectedScriptManager no longer exists?

[kozy, 2016-03-17 21:27:58]

Rebased and answered comments.

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt
(right):

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt:4:
VM:1 Uncaught SyntaxError: Invalid or unexpected token
On 2016/03/17 21:24:22, pfeldman wrote:
> Do we know why these changed?

Yes, it's because SyntaxError message with this CL doesn't contain stack trace.
Before CL it contains frames from InjectedScript.

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1812983002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:136:
injectedScript = m_injectedScriptManager->findInjectedScript(errorString,
executionContextId.fromJust());
On 2016/03/17 21:24:22, pfeldman wrote:
> Is there a chance m_injectedScriptManager no longer exists?

We keep OwnPtr to manager in this agent.

[kozy, 2016-03-17 21:29:32]

Patchset #2 (id:20001) has been deleted

[dgozman, 2016-03-18 00:04:33]

lgtm

https://codereview.chromium.org/1812983002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1812983002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:465: if
(wasThrown)
Should we kill this entirely and just set this bool on the upper level?

[kozy, 2016-03-18 00:41:39]

https://codereview.chromium.org/1812983002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1812983002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:465: if
(wasThrown)
On 2016/03/18 00:04:33, dgozman wrote:
> Should we kill this entirely and just set this bool on the upper level?

There is call sides that has wasThrown and doesn't have exceptionDetails.

[kozy, 2016-03-18 00:41:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:42:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812983002/60001

[commit-bot: I haz the power, 2016-03-18 00:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:46:53]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-03-18 00:47:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:48:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812983002/60001

[commit-bot: I haz the power, 2016-03-18 00:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:49:54]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kozy, 2016-03-18 04:47:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-03-18 04:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812983002/60001

[commit-bot: I haz the power, 2016-03-18 06:46:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-18 06:47:42]

Description was changed from

==========
[DevTools] Move evaluate from InjectedScriptSource.js to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move evaluate from InjectedScriptSource.js to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3
Cr-Commit-Position: refs/heads/master@{#381902}
==========

[commit-bot: I haz the power, 2016-03-18 06:47:44]

Patchset 3 (id:??) landed as
https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3
Cr-Commit-Position: refs/heads/master@{#381902}

[achuithb, 2016-04-07 01:25:28]

On 2016/03/18 06:47:44, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3
> Cr-Commit-Position: refs/heads/master@{#381902}

http://crbug.com/597820

[achuithb, 2016-04-07 01:26:45]

On 2016/04/07 01:25:28, achuithb wrote:
> On 2016/03/18 06:47:44, commit-bot: I haz the power wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/07892da08747cb20df3856387961dff5f4902cf3
> > Cr-Commit-Position: refs/heads/master@{#381902}
> 
> http://crbug.com/597820

Telemetry is no longer able to see the GAIA webview object in the login screen
after this change.