[DevTools] Move evaluateOnCallFrame to native

third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp

 /*
  * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 167 matching lines @@
     v8::Local<v8::Value> info[] = { scriptHostWrapper, windowGlobal, v8::Number::New(context->GetIsolate(), id) };
     v8::MicrotasksScope microtasksScope(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);
     v8::Local<v8::Value> injectedScriptValue;
     if (!function->Call(context, windowGlobal, WTF_ARRAY_LENGTH(info), info).ToLocal(&injectedScriptValue))
         return v8::Local<v8::Object>();
     if (!injectedScriptValue->IsObject())
         return v8::Local<v8::Object>();
     return injectedScriptValue.As<v8::Object>();
 }
 
+
+InjectedScriptManager::InjectScopeExtensionByName::InjectScopeExtensionByName(ErrorString* errorString, InjectedScript* injectedScript, bool injectToAll, const String16& name)
+    : m_isolate(injectedScript->isolate())
+    , m_symbol(V8Debugger::scopeExtensionSymbol(injectedScript->isolate()))
+    , m_context(injectedScript->context())
+    , m_globals(v8::Array::New(injectedScript->isolate()))

[dgozman, 2016/03/17 19:16:11]

Let's not create array when we don't need it.

[kozy, 2016/03/17 20:48:56]

Done.

+    , m_hasError(false)
+{
+    if (name.isEmpty())
+        return;
+
+    v8::Local<v8::Object> scopeExtension;
+    if (!injectedScript->scopeExtensionByName(errorString, name).ToLocal(&scopeExtension)) {
+        m_hasError = true;
+        return;
+    }
+
+    if (injectToAll) {
+        InjectedScriptManager::IdToInjectedScriptMap::iterator end = injectedScript->m_manager->m_idToInjectedScript.end();
+        for (InjectedScriptManager::IdToInjectedScriptMap::iterator it = injectedScript->m_manager->m_idToInjectedScript.begin(); it != end; ++it) {
+            if (it->second->canAccessInspectedWindow())
+                setOnGlobal(it->second->context()->Global(), scopeExtension);
+        }
+    } else {
+        setOnGlobal(m_context->Global(), scopeExtension);
+    }
+}
+
+InjectedScriptManager::InjectScopeExtensionByName::~InjectScopeExtensionByName()
+{
+    if (!m_globals->Length())
+        return;
+    v8::Local<v8::Symbol> scopeExtensionSymbolValue = V8Debugger::scopeExtensionSymbol(m_isolate);
+    for (size_t i = 0; i < m_globals->Length(); ++i) {
+        v8::Local<v8::Value> global;
+        bool success = m_globals->Get(m_context, i).ToLocal(&global);

[dgozman, 2016/03/17 19:16:11]

Let's use vector.

[kozy, 2016/03/17 20:48:56]

Done.

+        ASSERT_UNUSED(success, success);
+        global->ToObject(m_context).ToLocalChecked()->Delete(m_context, scopeExtensionSymbolValue);
+    }
+}
+
+void InjectedScriptManager::InjectScopeExtensionByName::setOnGlobal(v8::Local<v8::Object> global, v8::Local<v8::Object> scopeExtension)
+{
+    bool success = global->Set(m_context, m_symbol, scopeExtension).FromMaybe(false);
+    ASSERT_UNUSED(success, success);
+    success = m_globals->Set(m_context, m_globals->Length(), global).FromMaybe(false);
+    ASSERT_UNUSED(success, success);
+}
+
 } // namespace blink