Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1789633002: more shader-->sp conversions (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : all of dm now builds w/o legacy #

Total comments: 16

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -733 lines) Patch
M gm/gradientDirtyLaundry.cpp View 2 chunks +10 lines, -16 lines 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M gm/gradients.cpp View 1 2 3 4 19 chunks +75 lines, -97 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 1 2 3 4 2 chunks +81 lines, -100 lines 0 comments Download
M gm/gradients_no_texture.cpp View 1 2 3 chunks +14 lines, -17 lines 0 comments Download
M gm/gradtext.cpp View 4 chunks +12 lines, -15 lines 0 comments Download
M gm/hairmodes.cpp View 1 2 3 chunks +4 lines, -6 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefromyuvtextures.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M gm/imagetoyuvplanes.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M gm/lcdblendmodes.cpp View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M gm/lumafilter.cpp View 1 2 4 chunks +9 lines, -16 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 2 6 chunks +13 lines, -18 lines 0 comments Download
M gm/ovals.cpp View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M gm/patch.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M gm/perspshaders.cpp View 1 2 3 chunks +9 lines, -12 lines 0 comments Download
M gm/pictureimagegenerator.cpp View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M gm/pictureshader.cpp View 1 2 3 3 chunks +12 lines, -15 lines 0 comments Download
M gm/pictureshadertile.cpp View 1 2 3 chunks +8 lines, -10 lines 1 comment Download
M gm/rectangletexture.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M gm/rects.cpp View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download
M gm/roundrects.cpp View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M gm/samplerstress.cpp View 1 2 3 3 chunks +6 lines, -11 lines 0 comments Download
M gm/shaderbounds.cpp View 1 2 3 4 chunks +18 lines, -18 lines 0 comments Download
M gm/shadertext.cpp View 1 2 3 5 chunks +15 lines, -15 lines 0 comments Download
M gm/shadertext2.cpp View 1 2 3 2 chunks +7 lines, -9 lines 0 comments Download
M gm/shadertext3.cpp View 1 2 3 2 chunks +6 lines, -10 lines 0 comments Download
M gm/shadows.cpp View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M gm/shallowgradient.cpp View 1 2 3 2 chunks +12 lines, -16 lines 0 comments Download
M gm/skbug_257.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M gm/srcmode.cpp View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M gm/surface.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M gm/tablecolorfilter.cpp View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
M gm/textbloblooper.cpp View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M gm/textblobshader.cpp View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 2 3 4 1 chunk +12 lines, -12 lines 0 comments Download
M gm/tiledscaledbitmap.cpp View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M gm/tilemodes.cpp View 1 2 3 4 chunks +11 lines, -13 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 2 3 4 chunks +11 lines, -12 lines 0 comments Download
M gm/tinybitmap.cpp View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M gm/transparency.cpp View 1 2 3 4 2 chunks +7 lines, -12 lines 0 comments Download
M gm/vertices.cpp View 1 2 3 4 chunks +14 lines, -15 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M gm/xfermodes.cpp View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M gm/xfermodes2.cpp View 1 2 3 4 chunks +9 lines, -13 lines 0 comments Download
M gm/xfermodes3.cpp View 1 2 3 4 3 chunks +13 lines, -18 lines 0 comments Download
M tests/BitmapHeapTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/GradientTest.cpp View 11 chunks +25 lines, -47 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/PaintImageFilterTest.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M tests/PictureShaderTest.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M tests/PictureTest.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ShaderOpacityTest.cpp View 2 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789633002/20001
4 years, 9 months ago (2016-03-11 14:12:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 14:31:06 UTC) #5
reed1
4 years, 9 months ago (2016-03-13 04:22:28 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789633002/60001
4 years, 9 months ago (2016-03-13 04:22:53 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-13 04:32:24 UTC) #11
f(malita)
LGTM w/ some nits. https://codereview.chromium.org/1789633002/diff/60001/gm/gradients.cpp File gm/gradients.cpp (right): https://codereview.chromium.org/1789633002/diff/60001/gm/gradients.cpp#newcode465 gm/gradients.cpp:465: paint1.setShader(sweep); nit: move https://codereview.chromium.org/1789633002/diff/60001/gm/gradients.cpp#newcode467 gm/gradients.cpp:467: ...
4 years, 9 months ago (2016-03-13 16:18:02 UTC) #12
reed1
https://codereview.chromium.org/1789633002/diff/60001/gm/gradients.cpp File gm/gradients.cpp (right): https://codereview.chromium.org/1789633002/diff/60001/gm/gradients.cpp#newcode465 gm/gradients.cpp:465: paint1.setShader(sweep); On 2016/03/13 16:18:01, f(malita) wrote: > nit: move ...
4 years, 9 months ago (2016-03-13 18:25:24 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789633002/80001
4 years, 9 months ago (2016-03-13 18:25:44 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-13 18:35:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789633002/80001
4 years, 9 months ago (2016-03-13 19:31:10 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/ce563cdd48ec7ce4e0420dd88760df9be9dba50c
4 years, 9 months ago (2016-03-13 19:32:41 UTC) #22
reed1
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1790353002/ by reed@google.com. ...
4 years, 9 months ago (2016-03-13 20:01:34 UTC) #23
f(malita)
4 years, 9 months ago (2016-03-13 20:25:50 UTC) #24
Message was sent while issue was closed. 
https://codereview.chromium.org/1789633002/diff/80001/gm/pictureshadertile.cpp
File gm/pictureshadertile.cpp (right):

https://codereview.chromium.org/1789633002/diff/80001/gm/pictureshadertile.cp...
gm/pictureshadertile.cpp:123: pictureRef = offsetPicture;
Heh, yeah, this is assigning offsetPicture -> picture and not just switching the
ref :)

I think we can make pictureRef a plain sk_sp<SkPicture> and forget about it.

Powered by Google App Engine
This is Rietveld 408576698