tests/DrawBitmapRectTest.cpp - Issue 1789633002: more shader-->sp conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/DrawBitmapRectTest.cpp

Issue 1789633002: more shader-->sp conversions (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/DrawBitmapRectTest.cpp

diff --git a/tests/DrawBitmapRectTest.cpp b/tests/DrawBitmapRectTest.cpp

index 88b9437935cebe326a2ce51b0ebe7c7ecdfc91b0..8928d4c90959d2d32f609609fd31126041ad2de1 100644

--- a/tests/DrawBitmapRectTest.cpp

+++ b/tests/DrawBitmapRectTest.cpp

@@ -195,11 +195,9 @@ static void test_wacky_bitmapshader(skiatest::Reporter* reporter,

0.0078740157f,

SkIntToScalar(239),

0, 0, SK_Scalar1);

- SkShader* s = SkShader::CreateBitmapShader(bm, SkShader::kRepeat_TileMode,

- SkShader::kRepeat_TileMode, &matrix);

SkPaint paint;

- paint.setShader(s)->unref();

+ paint.setShader(SkShader::MakeBitmapShader(bm, SkShader::kRepeat_TileMode,

+ SkShader::kRepeat_TileMode, &matrix));

SkRect r = SkRect::MakeXYWH(681, 239, 695, 253);

c.drawRect(r, paint);