Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785473002: SkImage now has makeShader to return sk_sp (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : use build guard for impl of newShader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M bench/SkLinearBitmapPipelineBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/SkLinearBitmapPipelineGM.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/image_shader.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/rectangletexture.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +7 lines, -3 lines 0 comments Download
M samplecode/SampleFilterQuality.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage.cpp View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M src/image/SkImageShader.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/FlattenableFactoryToName.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/ImageNewShaderTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/SkColor4fTest.cpp View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
reed1
4 years, 9 months ago (2016-03-09 21:39:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785473002/1
4 years, 9 months ago (2016-03-09 21:39:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 21:52:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785473002/20001
4 years, 9 months ago (2016-03-09 22:11:32 UTC) #9
f(malita)
https://codereview.chromium.org/1785473002/diff/20001/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/1785473002/diff/20001/src/core/SkDevice.cpp#newcode207 src/core/SkDevice.cpp:207: pnt.setShader(shader); move or set directly https://codereview.chromium.org/1785473002/diff/20001/src/image/SkImage.cpp File src/image/SkImage.cpp (right): ...
4 years, 9 months ago (2016-03-09 22:20:54 UTC) #10
reed1
https://codereview.chromium.org/1785473002/diff/20001/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/1785473002/diff/20001/src/core/SkDevice.cpp#newcode207 src/core/SkDevice.cpp:207: pnt.setShader(shader); On 2016/03/09 22:20:54, f(malita) wrote: > move or ...
4 years, 9 months ago (2016-03-09 22:30:34 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785473002/40001
4 years, 9 months ago (2016-03-09 22:30:51 UTC) #13
f(malita)
lgtm
4 years, 9 months ago (2016-03-09 22:35:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785473002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785473002/40001
4 years, 9 months ago (2016-03-09 22:39:41 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:47:38 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5671c5b9124f17d33bc14b6d347cdc6fe5d19dc8

Powered by Google App Engine
This is Rietveld 408576698