Change colorspace's number of components to be unsigned

Change colorspace's number of components to be unsigned

Also remove unnecessary casts.

BUG=pdfium:29
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/79fcb5f6fa61967517566100415972848edefd24

[Wei Li, 2016-03-10 19:08:33]

Description was changed from

==========
Change colorspace's number of components to be unsigned

BUG=pdfium:29
==========

to

==========
Change colorspace's number of components to be unsigned

Also remove unnecessary casts.

BUG=pdfium:29
==========

[Wei Li, 2016-03-10 19:22:29]

weili@chromium.org changed reviewers:
+ tsepez@chromium.org

[Wei Li, 2016-03-10 19:22:29]

PTAL, thanks

[Tom Sepez, 2016-03-10 19:42:20]

Can you make a quick check that they aren't doing something obnoxious like "-1
means unknown number of componets"?  Seems unlikely, but checking the uses of
the variables you just changed seems prudent.

LGTM otherwise.

https://codereview.chromium.org/1783933002/diff/1/core/include/fpdfapi/fpdf_r...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/1783933002/diff/1/core/include/fpdfapi/fpdf_r...
core/include/fpdfapi/fpdf_resource.h:514: 
nit: while we're at it, no blank line here, line 516, or line 518.

[Wei Li, 2016-03-10 20:14:41]

Thanks for the reminder. Yes, there are places like you said are harder to be
replaced with an unsigned.

This change is safe since there are no negative values can be passed in. I also
modified the call sites to make this more obvious.

https://codereview.chromium.org/1783933002/diff/1/core/include/fpdfapi/fpdf_r...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/1783933002/diff/1/core/include/fpdfapi/fpdf_r...
core/include/fpdfapi/fpdf_resource.h:514: 
On 2016/03/10 19:42:19, Tom Sepez wrote:
> nit: while we're at it, no blank line here, line 516, or line 518.

Done.

[Wei Li, 2016-03-10 20:35:18]

Description was changed from

==========
Change colorspace's number of components to be unsigned

Also remove unnecessary casts.

BUG=pdfium:29
==========

to

==========
Change colorspace's number of components to be unsigned

Also remove unnecessary casts.

BUG=pdfium:29
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/79fcb5f6fa61967517566100415972848ede...
==========

[Wei Li, 2016-03-10 20:35:19]

Committed patchset #2 (id:20001) manually as
79fcb5f6fa61967517566100415972848edefd24 (presubmit successful).