core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp - Issue 1783933002: Change colorspace's number of components to be unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp

Issue 1783933002: Change colorspace's number of components to be unsigned (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp

index 0f9b88e638ea107e62079dc01f4880b5235e0425..3be74c5ce846c46f5c5ce8e367ae75e64d7de4f6 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp

@@ -917,8 +917,8 @@ CFX_DIBitmap* CPDF_RenderStatus::LoadSMask(CPDF_Dictionary* pSMaskDict,

if (pCS) {

FX_FLOAT R, G, B;

FX_DWORD comps = 8;

- if (pCS->CountComponents() > static_cast<int32_t>(comps)) {

- comps = (FX_DWORD)pCS->CountComponents();

+ if (pCS->CountComponents() > comps) {

+ comps = pCS->CountComponents();

}

CFX_FixedBufGrow<FX_FLOAT, 8> float_array(comps);

FX_FLOAT* pFloats = float_array;