core/src/fpdfapi/fpdf_page/pageint.h - Issue 1783933002: Change colorspace's number of components to be unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/pageint.h

Issue 1783933002: Change colorspace's number of components to be unsigned (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/pageint.h

diff --git a/core/src/fpdfapi/fpdf_page/pageint.h b/core/src/fpdfapi/fpdf_page/pageint.h

index 030e734edd55a6b6c59a1bf78c4663fd782abff7..517c0a405502b7e918fcf10af72f54e434477772 100644

--- a/core/src/fpdfapi/fpdf_page/pageint.h

+++ b/core/src/fpdfapi/fpdf_page/pageint.h

@@ -396,12 +396,12 @@ class CPDF_IccProfile {

public:

CPDF_IccProfile(const uint8_t* pData, FX_DWORD dwSize);

~CPDF_IccProfile();

- int32_t GetComponents() const { return m_nSrcComponents; }

+ FX_DWORD GetComponents() const { return m_nSrcComponents; }

FX_BOOL m_bsRGB;

void* m_pTransform;

private:

- int32_t m_nSrcComponents;

+ FX_DWORD m_nSrcComponents;

};

class CPDF_DeviceCS : public CPDF_ColorSpace {