Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1906213002: Remove one warning from PDFium compilation in Cros (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove one warning from PDFium compilation in Cros The original code caused an optimization warning when gcc tries to get rid of 'count > m_Length - index' in CFX_ByteStringC::Mid() while assuming there is no signed integer overflow. This could also be avoided once FX_STRSIZE is no longer a signed integer type. Committed: https://pdfium.googlesource.com/pdfium/+/6f5325e538f31a37bb97a6a71f5c8cd64c6f7639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Wei Li
PTAL, thanks
4 years, 8 months ago (2016-04-21 21:38:14 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-21 22:02:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906213002/1
4 years, 8 months ago (2016-04-21 22:19:35 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 22:31:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6f5325e538f31a37bb97a6a71f5c8cd64c6f...

Powered by Google App Engine
This is Rietveld 408576698