Change the code to avoid three unit test failures on release build

Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
release builds, because Clang aggressively optimizes the code.
Adding some usage of the return value of a function can avoid the function
being optimized away by Clang.

Committed: https://pdfium.googlesource.com/pdfium/+/14f5aeb5a46f330bd9386cd698fa25da3775d909

[Wei Li, 2016-04-22 21:47:56]

Description was changed from

==========
Change the code to avoid three unit test failures on Release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
Release builds, because Clang aggressively optimizes the code.
Add some usage of the return value of a function can avoid Clang's
optimizating away that function.
==========

to

==========
Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
Release builds, because Clang aggressively optimizes the code.
Add some usage of the return value of a function can avoid Clang's
optimizing away that function.
==========

[Wei Li, 2016-04-22 21:50:17]

Description was changed from

==========
Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
Release builds, because Clang aggressively optimizes the code.
Add some usage of the return value of a function can avoid Clang's
optimizing away that function.
==========

to

==========
Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
release builds, because Clang aggressively optimizes the code.
Adding some usage of the return value of a function can avoid the function
being optimized away by Clang.
==========

[Wei Li, 2016-04-22 21:53:44]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-04-22 21:53:45]

PTAL, thanks

[Lei Zhang, 2016-04-23 00:53:45]

lgtm

[Wei Li, 2016-04-23 02:03:28]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-04-23 02:03:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1915693002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1915693002/1

[commit-bot: I haz the power, 2016-04-23 02:18:34]

Description was changed from

==========
Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
release builds, because Clang aggressively optimizes the code.
Adding some usage of the return value of a function can avoid the function
being optimized away by Clang.
==========

to

==========
Change the code to avoid three unit test failures on release build

We have three failed unit tests -- FX_AllocOverflow(),
FX_AllocOverflow2D(), and FX_TryAllocOverflow() on Linux and Mac
release builds, because Clang aggressively optimizes the code.
Adding some usage of the return value of a function can avoid the function
being optimized away by Clang.

Committed:
https://pdfium.googlesource.com/pdfium/+/14f5aeb5a46f330bd9386cd698fa25da3775...
==========

[commit-bot: I haz the power, 2016-04-23 02:18:35]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/14f5aeb5a46f330bd9386cd698fa25da3775...