core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp - Issue 1783933002: Change colorspace's number of components to be unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

Issue 1783933002: Change colorspace's number of components to be unsigned (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

index e4876a0d2682dda00c55fb6c67789f9cbe2eff96..92e0ff4d122473fc969e1080f1195ffb79eadbb6 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp

@@ -832,7 +832,7 @@ void CPDF_RenderStatus::DrawShading(CPDF_ShadingPattern* pPattern,

CPDF_Array* pBackColor =

pPattern->m_pShadingObj->GetDict()->GetArrayBy("Background");

if (pBackColor &&

- pBackColor->GetCount() >= (FX_DWORD)pColorSpace->CountComponents()) {

+ pBackColor->GetCount() >= pColorSpace->CountComponents()) {

CFX_FixedBufGrow<FX_FLOAT, 16> comps(pColorSpace->CountComponents());

for (int i = 0; i < pColorSpace->CountComponents(); i++) {

comps[i] = pBackColor->GetNumberAt(i);