Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed)

Created:
4 years, 9 months ago by rjshade

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng

Base URL:
https://chromium.googlesource.com/chromium/src.git@116388439

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. The only place in the codebase that returns something other than QuicTime::Zero() is the DelayAlarm in PacketDroppingTestWriter. I've the implementation of OnAlarm in there to set the alarm directly to the new time, rather than relying on the return value. Merge internal change: 116389752 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -74 lines)			Patch
M	net/quic/quic_alarm.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	net/quic/quic_alarm.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	net/quic/quic_alarm_test.cc	View	3 chunks	+3 lines, -15 lines	0 comments	Download
M	net/quic/quic_chromium_connection_helper_test.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	net/quic/quic_client_promised_info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_client_promised_info.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	6 chunks	+6 lines, -25 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	net/tools/quic/quic_epoll_connection_helper_test.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	net/tools/quic/quic_time_wait_list_manager.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/tools/quic/test_tools/packet_dropping_test_writer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/packet_dropping_test_writer.cc	View	3 chunks	+11 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1782743005 Patch 1

Dependent Patchsets:

Issue 1786493003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages