net/tools/quic/quic_time_wait_list_manager.cc - Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_time_wait_list_manager.cc

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper_test.cc ('k') | net/tools/quic/test_tools/packet_dropping_test_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/tools/quic/quic_time_wait_list_manager.cc

diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc

index 64ff05e158edfa5fe1271bb926971c552989d2a6..91c48d089b0882c338fb58d00d27f9c9e069af8d 100644

--- a/net/tools/quic/quic_time_wait_list_manager.cc

+++ b/net/tools/quic/quic_time_wait_list_manager.cc

@@ -34,10 +34,8 @@ class ConnectionIdCleanUpAlarm : public QuicAlarm::Delegate {

QuicTimeWaitListManager* time_wait_list_manager)

: time_wait_list_manager_(time_wait_list_manager) {}

- QuicTime OnAlarm() override {

+ void OnAlarm() override {

time_wait_list_manager_->CleanUpOldConnectionIds();

- // Let the time wait manager register the alarm at appropriate time.

- return QuicTime::Zero();

}

private:

« no previous file with comments | « net/tools/quic/quic_epoll_connection_helper_test.cc ('k') | net/tools/quic/test_tools/packet_dropping_test_writer.h » ('j') | no next file with comments »