Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: net/quic/quic_alarm.cc

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_alarm.h ('k') | net/quic/quic_alarm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_alarm.cc
diff --git a/net/quic/quic_alarm.cc b/net/quic/quic_alarm.cc
index 371cbe98d7f32aa356c741e64939e675e41ee20e..ca407b52d914dd9a8adee1d023cccd6cf0596ad9 100644
--- a/net/quic/quic_alarm.cc
+++ b/net/quic/quic_alarm.cc
@@ -53,14 +53,7 @@ void QuicAlarm::Fire() {
}
deadline_ = QuicTime::Zero();
- QuicTime new_deadline = delegate_->OnAlarm();
- // delegate_->OnAlarm() might call Set(), in which case deadline_
- // will already contain the new value, so don't overwrite it. Also,
- // OnAlarm() might delete |this| so check |deadline| before
- // |deadline_|.
- if (new_deadline.IsInitialized() && !IsSet()) {
- Set(new_deadline);
- }
+ delegate_->OnAlarm();
}
} // namespace net
« no previous file with comments | « net/quic/quic_alarm.h ('k') | net/quic/quic_alarm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698