Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: net/tools/quic/quic_epoll_connection_helper_test.cc

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/tools/quic/quic_epoll_connection_helper.h" 5 #include "net/tools/quic/quic_epoll_connection_helper.h"
6 6
7 #include "net/quic/crypto/quic_random.h" 7 #include "net/quic/crypto/quic_random.h"
8 #include "net/tools/quic/test_tools/mock_epoll_server.h" 8 #include "net/tools/quic/test_tools/mock_epoll_server.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 using net::test::MockEpollServer; 11 using net::test::MockEpollServer;
12 12
13 namespace net { 13 namespace net {
14 namespace test { 14 namespace test {
15 namespace { 15 namespace {
16 16
17 class TestDelegate : public QuicAlarm::Delegate { 17 class TestDelegate : public QuicAlarm::Delegate {
18 public: 18 public:
19 TestDelegate() : fired_(false) {} 19 TestDelegate() : fired_(false) {}
20 20
21 QuicTime OnAlarm() override { 21 void OnAlarm() override { fired_ = true; }
22 fired_ = true;
23 return QuicTime::Zero();
24 }
25 22
26 bool fired() const { return fired_; } 23 bool fired() const { return fired_; }
27 24
28 private: 25 private:
29 bool fired_; 26 bool fired_;
30 }; 27 };
31 28
32 class QuicEpollConnectionHelperTest : public ::testing::Test { 29 class QuicEpollConnectionHelperTest : public ::testing::Test {
33 protected: 30 protected:
34 QuicEpollConnectionHelperTest() : helper_(&epoll_server_) {} 31 QuicEpollConnectionHelperTest() : helper_(&epoll_server_) {}
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 EXPECT_TRUE(alarm->IsSet()); 160 EXPECT_TRUE(alarm->IsSet());
164 161
165 // Update it with an uninitialized time and ensure it's cancelled. 162 // Update it with an uninitialized time and ensure it's cancelled.
166 alarm->Update(QuicTime::Zero(), QuicTime::Delta::FromMicroseconds(1)); 163 alarm->Update(QuicTime::Zero(), QuicTime::Delta::FromMicroseconds(1));
167 EXPECT_FALSE(alarm->IsSet()); 164 EXPECT_FALSE(alarm->IsSet());
168 } 165 }
169 166
170 } // namespace 167 } // namespace
171 } // namespace test 168 } // namespace test
172 } // namespace net 169 } // namespace net
OLDNEW
« no previous file with comments | « net/tools/quic/quic_dispatcher.cc ('k') | net/tools/quic/quic_time_wait_list_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698