Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: net/quic/quic_chromium_connection_helper_test.cc

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_alarm_test.cc ('k') | net/quic/quic_client_promised_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_chromium_connection_helper.h" 5 #include "net/quic/quic_chromium_connection_helper.h"
6 6
7 #include "net/quic/test_tools/mock_clock.h" 7 #include "net/quic/test_tools/mock_clock.h"
8 #include "net/quic/test_tools/mock_random.h" 8 #include "net/quic/test_tools/mock_random.h"
9 #include "net/quic/test_tools/test_task_runner.h" 9 #include "net/quic/test_tools/test_task_runner.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace net { 12 namespace net {
13 namespace test { 13 namespace test {
14 namespace { 14 namespace {
15 15
16 class TestDelegate : public QuicAlarm::Delegate { 16 class TestDelegate : public QuicAlarm::Delegate {
17 public: 17 public:
18 TestDelegate() : fired_(false) {} 18 TestDelegate() : fired_(false) {}
19 19
20 QuicTime OnAlarm() override { 20 void OnAlarm() override { fired_ = true; }
21 fired_ = true;
22 return QuicTime::Zero();
23 }
24 21
25 bool fired() const { return fired_; } 22 bool fired() const { return fired_; }
26 void Clear() { fired_ = false; } 23 void Clear() { fired_ = false; }
27 24
28 private: 25 private:
29 bool fired_; 26 bool fired_;
30 }; 27 };
31 28
32 class QuicChromiumConnectionHelperTest : public ::testing::Test { 29 class QuicChromiumConnectionHelperTest : public ::testing::Test {
33 protected: 30 protected:
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 EXPECT_TRUE(alarm->IsSet()); 177 EXPECT_TRUE(alarm->IsSet());
181 178
182 // Update it with an uninitialized time and ensure it's cancelled. 179 // Update it with an uninitialized time and ensure it's cancelled.
183 alarm->Update(QuicTime::Zero(), QuicTime::Delta::FromMicroseconds(1)); 180 alarm->Update(QuicTime::Zero(), QuicTime::Delta::FromMicroseconds(1));
184 EXPECT_FALSE(alarm->IsSet()); 181 EXPECT_FALSE(alarm->IsSet());
185 } 182 }
186 183
187 } // namespace 184 } // namespace
188 } // namespace test 185 } // namespace test
189 } // namespace net 186 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_alarm_test.cc ('k') | net/quic/quic_client_promised_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698