Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: net/quic/quic_client_promised_info.h

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_chromium_connection_helper_test.cc ('k') | net/quic/quic_client_promised_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_ 5 #ifndef NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_
6 #define NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_ 6 #define NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_
7 7
8 #include <sys/types.h> 8 #include <sys/types.h>
9 #include <string> 9 #include <string>
10 10
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 const std::string url() const { return url_; } 76 const std::string url() const { return url_; }
77 77
78 private: 78 private:
79 friend class test::QuicClientPromisedInfoPeer; 79 friend class test::QuicClientPromisedInfoPeer;
80 80
81 class CleanupAlarm : public QuicAlarm::Delegate { 81 class CleanupAlarm : public QuicAlarm::Delegate {
82 public: 82 public:
83 explicit CleanupAlarm(QuicClientPromisedInfo* promised) 83 explicit CleanupAlarm(QuicClientPromisedInfo* promised)
84 : promised_(promised) {} 84 : promised_(promised) {}
85 85
86 QuicTime OnAlarm() override; 86 void OnAlarm() override;
87 87
88 QuicClientPromisedInfo* promised_; 88 QuicClientPromisedInfo* promised_;
89 }; 89 };
90 90
91 void Reset(QuicRstStreamErrorCode error_code); 91 void Reset(QuicRstStreamErrorCode error_code);
92 92
93 QuicAsyncStatus FinalValidation(); 93 QuicAsyncStatus FinalValidation();
94 94
95 QuicClientSessionBase* session_; 95 QuicClientSessionBase* session_;
96 QuicConnectionHelperInterface* helper_; 96 QuicConnectionHelperInterface* helper_;
97 QuicStreamId id_; 97 QuicStreamId id_;
98 std::string url_; 98 std::string url_;
99 std::unique_ptr<SpdyHeaderBlock> request_headers_; 99 std::unique_ptr<SpdyHeaderBlock> request_headers_;
100 std::unique_ptr<SpdyHeaderBlock> response_headers_; 100 std::unique_ptr<SpdyHeaderBlock> response_headers_;
101 std::unique_ptr<SpdyHeaderBlock> client_request_headers_; 101 std::unique_ptr<SpdyHeaderBlock> client_request_headers_;
102 QuicClientPushPromiseIndex::Delegate* client_request_delegate_; 102 QuicClientPushPromiseIndex::Delegate* client_request_delegate_;
103 103
104 // The promise will commit suicide eventually if it is not claimed 104 // The promise will commit suicide eventually if it is not claimed
105 // by a GET first. 105 // by a GET first.
106 std::unique_ptr<QuicAlarm> cleanup_alarm_; 106 std::unique_ptr<QuicAlarm> cleanup_alarm_;
107 107
108 DISALLOW_COPY_AND_ASSIGN(QuicClientPromisedInfo); 108 DISALLOW_COPY_AND_ASSIGN(QuicClientPromisedInfo);
109 }; 109 };
110 110
111 } // namespace net 111 } // namespace net
112 112
113 #endif // NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_ 113 #endif // NET_QUIC_QUIC_CLIENT_PROMISED_INFO_H_
OLDNEW
« no previous file with comments | « net/quic/quic_chromium_connection_helper_test.cc ('k') | net/quic/quic_client_promised_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698