Issue 1778793002: Mozart: Make Snapshot immutable.

Issue 1778793002: Mozart: Make Snapshot immutable. (Closed)

Created:
4 years, 9 months ago by jeffbrown

Modified:
4 years, 9 months ago

Reviewers:
abarth

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@moz-2

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Mozart: Make Snapshot immutable. Follow the same pattern as the rest of the scene graph content objects. This will make it easier to implement hit testing safely. Moved the RenderFrame out of the Snapshot since it can go directly to the renderer then we don't need it anymore afterwards. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/28445a0ba661fcaa5ab3073d98ee7e239ee04612

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -131 lines)			Patch
M	services/gfx/compositor/compositor_engine.cc	View	5 chunks	+13 lines, -8 lines	0 comments	Download
M	services/gfx/compositor/graph/node_def.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	services/gfx/compositor/graph/snapshot.h	View	5 chunks	+34 lines, -46 lines	0 comments	Download
M	services/gfx/compositor/graph/snapshot.cc	View	3 chunks	+30 lines, -45 lines	0 comments	Download
M	services/gfx/compositor/renderer_state.h	View	3 chunks	+19 lines, -21 lines	0 comments	Download
M	services/gfx/compositor/renderer_state.cc	View	1 chunk	+4 lines, -8 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 5 (2 generated)

jeffbrown

4 years, 9 months ago (2016-03-09 22:22:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
28445a0ba661fcaa5ab3073d98ee7e239ee04612 (presubmit successful).