Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1775143004: Mozart: Directly associate the renderer with the view tree. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Directly associate the renderer with the view tree. Instead of hooking up the view tree to the renderer indirectly in the launcher application, give the Renderer interface to the View Manager to take care of instead. This change will allow the view manager to perform hit testing on the scene graph. It also simplifies the launcher somewhat. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e63ab215cdea2da68d02085c88afdf810ab1eacf

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -136 lines) Patch
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/renderers.mojom.dart View 1 5 chunks +72 lines, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_trees.mojom.dart View 1 12 chunks +262 lines, -4 lines 0 comments Download
M mojo/services/gfx/composition/interfaces/renderers.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/ui/views/interfaces/view_trees.mojom View 3 chunks +15 lines, -0 lines 0 comments Download
M services/gfx/compositor/backend/gpu_rasterizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_engine.h View 1 chunk +4 lines, -0 lines 0 comments Download
M services/gfx/compositor/compositor_engine.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M services/gfx/compositor/renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/gfx/compositor/renderer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/gfx/compositor/renderer_state.h View 1 chunk +4 lines, -0 lines 0 comments Download
M services/gfx/compositor/renderer_state.cc View 2 chunks +9 lines, -1 line 0 comments Download
M services/ui/launcher/launcher_view_tree.h View 3 chunks +3 lines, -21 lines 0 comments Download
M services/ui/launcher/launcher_view_tree.cc View 8 chunks +12 lines, -107 lines 0 comments Download
M services/ui/view_manager/view_registry.h View 2 chunks +11 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_registry.cc View 6 chunks +63 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_stub.h View 1 chunk +4 lines, -1 line 0 comments Download
M services/ui/view_manager/view_tree_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_tree_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M services/ui/view_manager/view_tree_state.h View 2 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-09 02:16:55 UTC) #2
abarth
lgtm https://codereview.chromium.org/1775143004/diff/1/mojo/services/gfx/composition/interfaces/renderers.mojom File mojo/services/gfx/composition/interfaces/renderers.mojom (right): https://codereview.chromium.org/1775143004/diff/1/mojo/services/gfx/composition/interfaces/renderers.mojom#newcode36 mojo/services/gfx/composition/interfaces/renderers.mojom:36: ResetRootScene(); ClearRootScene? We've sort of vaguely been following ...
4 years, 9 months ago (2016-03-09 03:48:41 UTC) #3
jeffbrown
On 2016/03/09 03:48:41, abarth wrote: > lgtm > > https://codereview.chromium.org/1775143004/diff/1/mojo/services/gfx/composition/interfaces/renderers.mojom > File mojo/services/gfx/composition/interfaces/renderers.mojom (right): > ...
4 years, 9 months ago (2016-03-09 19:06:36 UTC) #4
jeffbrown
4 years, 9 months ago (2016-03-09 22:22:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e63ab215cdea2da68d02085c88afdf810ab1eacf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698