Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1776643004: Mozart: Specify texture origin explicitly. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-3
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Specify texture origin explicitly. Previously we assumed the origin was always top-left but OpenGL likes to create textures with the origin in the bottom-left. Since we don't always get what we want in this life, let the client specify what origin it used. Maybe later we can grumble about it and replace (or augment) this with a more general means of specifying texture coordinates or texture matrices for rendering. Flipping the node's coordinate system upside-down in Spinning Cube has undesirable consequences on the input dispatch (since the events get flipped too, as expected) so it was time to remove the old hack and resolve the origin problem. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/bae77abe00df82bc66c7febfba7b8c5104f96ec9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -17 lines) Patch
M examples/ui/spinning_cube/spinning_cube_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/resources.mojom.dart View 1 4 chunks +69 lines, -0 lines 0 comments Download
M mojo/services/gfx/composition/cpp/formatting.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/gfx/composition/cpp/formatting.cc View 1 chunk +14 lines, -1 line 0 comments Download
M mojo/services/gfx/composition/interfaces/resources.mojom View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/skia/ganesh_image_factory.h View 4 chunks +5 lines, -1 line 0 comments Download
M mojo/skia/ganesh_image_factory.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M mojo/ui/ganesh_renderer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/ui/gl_renderer.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/ui/gl_renderer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/gfx/compositor/graph/scene_def.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/gfx/compositor/render/render_image.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/gfx/compositor/render/render_image.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-09 02:19:16 UTC) #2
abarth
LGTM I guess this is better than picking a winner.
4 years, 9 months ago (2016-03-09 03:52:03 UTC) #3
jeffbrown
4 years, 9 months ago (2016-03-09 22:22:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bae77abe00df82bc66c7febfba7b8c5104f96ec9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698