Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 177263002: Revert 252883 "Remove tests and code for showModalDialog" (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 252883 "Remove tests and code for showModalDialog" This CL broke show-modal-dialog tests in Blink. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/open-window-min-size.html,fast/events/scroll-event-during-modal-dialog.html,fast/events/show-modal-dialog-onblur-onfocus.html,fast/harness/show-modal-dialog.html > Remove tests and code for showModalDialog > > This deletes the chromium-side implementation logic and a few tests for > showModalDialog. I believe more simplification is possible to do without the > design constraints imposed by showModalDialog but we should probably start > small in case we run into unexpected compat issues. > > R=darin > BUG=345831 > > Review URL: https://codereview.chromium.org/165793003 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1 line) Patch
M trunk/src/chrome/browser/ui/browser_browsertest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A + trunk/src/chrome/test/data/showmodaldialog.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.h View 3 chunks +8 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +42 lines, -0 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/webkit_browsertest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M trunk/src/content/common/view_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/content/renderer/render_view_impl.cc View 2 chunks +22 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/render_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
A + trunk/src/content/test/data/error-body-no-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
MM trunk/src/third_party/webdriver/test_data/alerts.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haraken
6 years, 10 months ago (2014-02-24 07:49:27 UTC) #1
haraken
Committed patchset #1 manually as r252889.
6 years, 10 months ago (2014-02-24 07:49:49 UTC) #2
jamesr
6 years, 10 months ago (2014-02-24 17:06:02 UTC) #3
That's the point of this change - to break those tests :(

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698