Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(91)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: trunk/src/content/test/data/error-body-no-crash.html
Issue
177263002
:
Revert 252883 "Remove tests and code for showModalDialog" (Closed)
Base URL: svn://svn.chromium.org/chrome/
Patch Set:
Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
trunk/src/chrome/browser/ui/browser_browsertest.cc
trunk/src/chrome/test/data/showmodaldialog.html
trunk/src/content/browser/renderer_host/render_view_host_impl.h
trunk/src/content/browser/renderer_host/render_view_host_impl.cc
trunk/src/content/browser/renderer_host/render_widget_host_impl.h
trunk/src/content/browser/webkit_browsertest.cc
trunk/src/content/common/view_messages.h
trunk/src/content/renderer/render_view_impl.h
trunk/src/content/renderer/render_view_impl.cc
trunk/src/content/renderer/render_widget.h
trunk/src/content/test/data/error-body-no-crash.html
trunk/src/third_party/webdriver/test_data/alerts.html
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« trunk/src/content/renderer/render_widget.h
('k') |
trunk/src/third_party/webdriver/test_data/alerts.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <!-- The showModalDialog call will force a nested message loop, which will
1 <!-- The showModalDialog call will force a nested message loop, which will
2 receive the 404 body and crash. -->
2 receive the 404 body and crash. -->
3 <script src="page404.html"></script>
3 <script src="page404.html"></script>
4 <script>
4 <script>
5 window.showModalDialog("javascript:window.close();");
5 window.showModalDialog("javascript:window.close();");
6 </script>
6 </script>
OLD
NEW
« no previous file with comments
|
« trunk/src/content/renderer/render_widget.h
('k') |
trunk/src/third_party/webdriver/test_data/alerts.html »
('j') |
no next file with comments »
Issue 177263002: Revert 252883 "Remove tests and code for showModalDialog" (Closed)
Created 6 years, 9 months ago by haraken
Modified 6 years, 9 months ago
Reviewers: jamesr
Base URL: svn://svn.chromium.org/chrome/
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 177263002:
Revert 252883 "Remove tests and code for showModalDialog" (Closed)
Base URL: svn://svn.chromium.org/chrome/