Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165793003: Remove tests and code for showModalDialog (Closed)

Created:
6 years, 10 months ago by jamesr
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove tests and code for showModalDialog This deletes the chromium-side implementation logic and a few tests for showModalDialog. I believe more simplification is possible to do without the design constraints imposed by showModalDialog but we should probably start small in case we run into unexpected compat issues. R=darin BUG=345831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -136 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/showmodaldialog.html View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +0 lines, -42 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webkit_browsertest.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/error-body-no-crash.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/webdriver/test_data/alerts.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jamesr
6 years, 10 months ago (2014-02-21 21:40:14 UTC) #1
darin (slow to review)
LGTM
6 years, 10 months ago (2014-02-22 00:02:54 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-22 00:16:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/165793003/1
6 years, 10 months ago (2014-02-22 00:20:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 00:48:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=51526
6 years, 10 months ago (2014-02-22 00:48:14 UTC) #6
jschuh
ipc security lgtm: message removal.
6 years, 10 months ago (2014-02-22 00:55:42 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-22 00:55:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/165793003/1
6 years, 10 months ago (2014-02-22 00:58:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/165793003/1
6 years, 10 months ago (2014-02-22 01:36:14 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 06:25:17 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268446
6 years, 10 months ago (2014-02-22 06:25:17 UTC) #12
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-24 03:21:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/165793003/1
6 years, 10 months ago (2014-02-24 03:21:36 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 05:58:33 UTC) #15
Message was sent while issue was closed. 
Change committed as 252883

Powered by Google App Engine
This is Rietveld 408576698