Index: trunk/src/content/renderer/render_view_impl.cc |
=================================================================== |
--- trunk/src/content/renderer/render_view_impl.cc (revision 252888) |
+++ trunk/src/content/renderer/render_view_impl.cc (working copy) |
@@ -1714,8 +1714,6 @@ |
// equivalent of WebView::willEnterModalLoop. In the case of showModalDialog |
// it is particularly important that we do not call willEnterModalLoop as |
// that would defer resource loads for the dialog itself. |
- // TODO(jamesr): Now that we no longer support showModalDialog, see if we can |
- // simplify this logic. |
if (RenderThreadImpl::current()) // Will be NULL during unit tests. |
RenderThreadImpl::current()->DoNotNotifyWebKitOfModalLoop(); |
@@ -2424,6 +2422,28 @@ |
SetPendingWindowRect(initial_pos_); |
} |
+void RenderViewImpl::runModal() { |
+ DCHECK(did_show_) << "should already have shown the view"; |
+ |
+ // Don't allow further dialogs if we are waiting to swap out, since the |
+ // PageGroupLoadDeferrer in our stack prevents it. |
+ if (suppress_dialogs_until_swap_out_) |
+ return; |
+ |
+ // We must keep WebKit's shared timer running in this case in order to allow |
+ // showModalDialog to function properly. |
+ // |
+ // TODO(darin): WebKit should really be smarter about suppressing events and |
+ // timers so that we do not need to manage the shared timer in such a heavy |
+ // handed manner. |
+ // |
+ if (RenderThreadImpl::current()) // Will be NULL during unit tests. |
+ RenderThreadImpl::current()->DoNotSuspendWebKitSharedTimer(); |
+ |
+ SendAndRunNestedMessageLoop(new ViewHostMsg_RunModal( |
+ routing_id_, opener_id_)); |
+} |
+ |
bool RenderViewImpl::enterFullScreen() { |
Send(new ViewHostMsg_ToggleFullscreen(routing_id_, true)); |
return true; |