Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: trunk/src/content/browser/renderer_host/render_view_host_impl.h

Issue 177263002: Revert 252883 "Remove tests and code for showModalDialog" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/render_view_host_impl.h
===================================================================
--- trunk/src/content/browser/renderer_host/render_view_host_impl.h (revision 252888)
+++ trunk/src/content/browser/renderer_host/render_view_host_impl.h (working copy)
@@ -415,6 +415,7 @@
// RenderWidgetHost public overrides.
virtual void Init() OVERRIDE;
+ virtual void Shutdown() OVERRIDE;
virtual bool IsRenderView() const OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
virtual void GotFocus() OVERRIDE;
@@ -549,6 +550,7 @@
bool user_gesture);
void OnShowWidget(int route_id, const gfx::Rect& initial_pos);
void OnShowFullscreenWidget(int route_id);
+ void OnRunModal(int opener_id, IPC::Message* reply_msg);
void OnRenderViewReady();
void OnRenderProcessGone(int status, int error_code);
void OnNavigate(const IPC::Message& msg);
@@ -691,6 +693,12 @@
// Routing ID for the main frame's RenderFrameHost.
int main_frame_routing_id_;
+ // If we were asked to RunModal, then this will hold the reply_msg that we
+ // must return to the renderer to unblock it.
+ IPC::Message* run_modal_reply_msg_;
+ // This will hold the routing id of the RenderView that opened us.
+ int run_modal_opener_id_;
+
// Set to true when there is a pending ViewMsg_ShouldClose message. This
// ensures we don't spam the renderer with multiple beforeunload requests.
// When either this value or IsWaitingForUnloadACK is true, the value of
« no previous file with comments | « trunk/src/chrome/test/data/showmodaldialog.html ('k') | trunk/src/content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698