Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: trunk/src/content/browser/webkit_browsertest.cc

Issue 177263002: Revert 252883 "Remove tests and code for showModalDialog" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/webkit_browsertest.cc
===================================================================
--- trunk/src/content/browser/webkit_browsertest.cc (revision 252888)
+++ trunk/src/content/browser/webkit_browsertest.cc (working copy)
@@ -76,4 +76,19 @@
EXPECT_FALSE(shell()->web_contents()->IsCrashed());
}
+// This is a browser test because DumpRenderTree doesn't run nested message
+// loops. The failure case was that a nested message triggered from an element
+// that has signalled an error but had an open request would receive a body for
+// the request and crash/fail an assertion.
+const char kErrorBodyNoCrash[] =
+ "files/error-body-no-crash.html";
+IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, ErrorBodyNoCrash) {
+ ASSERT_TRUE(test_server()->Start());
+ GURL url = test_server()->GetURL(kErrorBodyNoCrash);
+
+ NavigateToURL(shell(), url);
+
+ EXPECT_FALSE(shell()->web_contents()->IsCrashed());
+}
+
} // namespace content
« no previous file with comments | « trunk/src/content/browser/renderer_host/render_widget_host_impl.h ('k') | trunk/src/content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698