Include the outline into the visual overflow

Include the outline into the visual overflow

This change makes the outline a first class visual effect instead
of being applied manually in the code. This removes the crazy fudge
factor logic that would grow *ANY* repaint rectangle by the maximal
outline on the page.

All test changes are progressions apart from 2 multi-column tests
regressing due to http://crbug.com/348064:
- fast/forms/range/slider-in-multi-column.html
- fast/forms/number/number-spinbutton-in-multi-column.html
A fix is in progress for the underlying issue that will make them
pass again (thanks to Morten Stenshome).

BUG=273904
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169659

[Julien - ping for review, 2014-03-11 22:03:00]

We talked about this with Morten and it seemed like he was fine with us moving
forward with this change. @Morten, if I misread you, please shout out!

The missing baselines are painting rects shrinking by the maximal outline. The 2
failing tests are real failures linked to https://crbug.com/348064 for which
Morten had a WIP fix: I was going to do the rebaseline with the failure, linking
to the previous bug, or a new one, as needed.

@eseidel, @leviw: PTAL!

[leviw_travelin_and_unemployed, 2014-03-11 22:51:09]

LGTM. You're missing your updated test expectations.

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Inline...
File Source/core/rendering/InlineFlowBox.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Inline...
Source/core/rendering/InlineFlowBox.cpp:835: // outline on root line boxes is
applying to the block and not to the lines.
Nit: is applied.

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:1550: // Add visual overflow from theme.
If you're going to get rid of the comment above, how about this super pointless
one, too? :p

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderTableSection.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderTableSection.cpp:885:
rowRenderer->addVisualEffectOverflow();
It seems odd that we didn't call this at all before.

[Julien - ping for review, 2014-03-12 03:18:58]

Will include the TestExpectations and updated baselines. Thanks for the review!

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Inline...
File Source/core/rendering/InlineFlowBox.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Inline...
Source/core/rendering/InlineFlowBox.cpp:835: // outline on root line boxes is
applying to the block and not to the lines.
On 2014/03/11 22:51:10, Levi wrote:
> Nit: is applied.

Done.

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:1550: // Add visual overflow from theme.
On 2014/03/11 22:51:10, Levi wrote:
> If you're going to get rid of the comment above, how about this super
pointless
> one, too? :p

Done.

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderTableSection.cpp (right):

https://codereview.chromium.org/176953008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderTableSection.cpp:885:
rowRenderer->addVisualEffectOverflow();
On 2014/03/11 22:51:10, Levi wrote:
> It seems odd that we didn't call this at all before.

Yeah, that wouldn't surprise me if some visual effects were broken on rows
because we are missing this call.

[mstensho (USE GERRIT), 2014-03-12 05:29:22]

On 2014/03/11 22:03:00, Julien Chaffraix - PST wrote:
> We talked about this with Morten and it seemed like he was fine with us moving
> forward with this change. @Morten, if I misread you, please shout out!

FTR, Yes, I'm fine with this. :)

[navabi, 2014-03-13 22:43:12]

The CQ bit was checked by navabi@google.com

[navabi, 2014-03-13 22:43:15]

The CQ bit was unchecked by navabi@google.com

[Julien - ping for review, 2014-03-17 16:34:24]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-17 16:34:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/176953008/100001

[commit-bot: I haz the power, 2014-03-17 17:17:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-17 17:17:19]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Julien - ping for review, 2014-03-17 18:26:10]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-17 18:26:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/176953008/100001

[commit-bot: I haz the power, 2014-03-17 19:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-17 19:06:47]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[Julien - ping for review, 2014-03-19 22:34:39]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/176953008/120001

[commit-bot: I haz the power, 2014-03-19 23:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 23:13:01]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Julien - ping for review, 2014-03-20 00:12:39]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-20 00:12:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/176953008/120001

[commit-bot: I haz the power, 2014-03-20 00:50:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 00:50:56]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Julien - ping for review, 2014-03-20 15:08:21]

The CQ bit was checked by jchaffraix@chromium.org

[commit-bot: I haz the power, 2014-03-20 15:08:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/176953008/120001

[commit-bot: I haz the power, 2014-03-20 15:40:09]

Change committed as 169659