Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed dumb bug caught by Mac. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 RenderTableCell* cell = toRenderTableCell(child); 171 RenderTableCell* cell = toRenderTableCell(child);
172 if (!cell->needsLayout()) 172 if (!cell->needsLayout())
173 cell->markForPaginationRelayoutIfNeeded(layouter); 173 cell->markForPaginationRelayoutIfNeeded(layouter);
174 if (cell->needsLayout()) { 174 if (cell->needsLayout()) {
175 cell->computeAndSetBlockDirectionMargins(table()); 175 cell->computeAndSetBlockDirectionMargins(table());
176 cell->layout(); 176 cell->layout();
177 } 177 }
178 } 178 }
179 } 179 }
180 180
181 m_overflow.clear();
182 addVisualEffectOverflow();
183
181 // We only ever need to repaint if our cells didn't, which means that they d idn't need 184 // We only ever need to repaint if our cells didn't, which means that they d idn't need
182 // layout, so we know that our bounds didn't change. This code is just makin g up for 185 // layout, so we know that our bounds didn't change. This code is just makin g up for
183 // the fact that we did not repaint in setStyle() because we had a layout hi nt. 186 // the fact that we did not repaint in setStyle() because we had a layout hi nt.
184 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the 187 // We cannot call repaint() because our clippedOverflowRectForRepaint() is t aken from the
185 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells. 188 // parent table, and being mid-layout, that is invalid. Instead, we repaint our cells.
186 if (selfNeedsLayout() && checkForRepaint()) { 189 if (selfNeedsLayout() && checkForRepaint()) {
187 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) { 190 for (RenderObject* child = firstChild(); child; child = child->nextSibli ng()) {
188 if (child->isTableCell()) { 191 if (child->isTableCell()) {
189 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) { 192 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) {
190 // FIXME: Is this needed with repaint After Layout? 193 // FIXME: Is this needed with repaint After Layout?
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 285
283 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
284 { 287 {
285 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
286 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
287 newRow->setStyle(newStyle.release()); 290 newRow->setStyle(newStyle.release());
288 return newRow; 291 return newRow;
289 } 292 }
290 293
291 } // namespace WebCore 294 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698