Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: Source/core/rendering/RenderListMarker.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed dumb bug caught by Mac. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLineBoxList.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserv ed.
5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net) 5 * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com) 6 * Copyright (C) 2010 Daniel Bates (dbates@intudata.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 1129
1130 if (paintInfo.phase != PaintPhaseForeground) 1130 if (paintInfo.phase != PaintPhaseForeground)
1131 return; 1131 return;
1132 1132
1133 if (style()->visibility() != VISIBLE) 1133 if (style()->visibility() != VISIBLE)
1134 return; 1134 return;
1135 1135
1136 LayoutPoint boxOrigin(paintOffset + location()); 1136 LayoutPoint boxOrigin(paintOffset + location());
1137 LayoutRect overflowRect(visualOverflowRect()); 1137 LayoutRect overflowRect(visualOverflowRect());
1138 overflowRect.moveBy(boxOrigin); 1138 overflowRect.moveBy(boxOrigin);
1139 overflowRect.inflate(maximalOutlineSize(paintInfo.phase));
1140 1139
1141 if (!paintInfo.rect.intersects(pixelSnappedIntRect(overflowRect))) 1140 if (!paintInfo.rect.intersects(pixelSnappedIntRect(overflowRect)))
1142 return; 1141 return;
1143 1142
1144 LayoutRect box(boxOrigin, size()); 1143 LayoutRect box(boxOrigin, size());
1145 1144
1146 IntRect marker = getRelativeMarkerRect(); 1145 IntRect marker = getRelativeMarkerRect();
1147 marker.moveBy(roundedIntPoint(boxOrigin)); 1146 marker.moveBy(roundedIntPoint(boxOrigin));
1148 1147
1149 GraphicsContext* context = paintInfo.context; 1148 GraphicsContext* context = paintInfo.context;
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
1842 1841
1843 if (clipToVisibleContent) 1842 if (clipToVisibleContent)
1844 computeRectForRepaint(repaintContainer, rect); 1843 computeRectForRepaint(repaintContainer, rect);
1845 else 1844 else
1846 rect = localToContainerQuad(FloatRect(rect), repaintContainer).enclosing BoundingBox(); 1845 rect = localToContainerQuad(FloatRect(rect), repaintContainer).enclosing BoundingBox();
1847 1846
1848 return rect; 1847 return rect;
1849 } 1848 }
1850 1849
1851 } // namespace WebCore 1850 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLineBoxList.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698