Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed dumb bug caught by Mac. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderReplica.cpp ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 { 647 {
648 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this); 648 ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
649 649
650 LayoutPoint adjustedPaintOffset = paintOffset + location(); 650 LayoutPoint adjustedPaintOffset = paintOffset + location();
651 651
652 PaintPhase paintPhase = paintInfo.phase; 652 PaintPhase paintPhase = paintInfo.phase;
653 653
654 if (!isRoot()) { 654 if (!isRoot()) {
655 LayoutRect overflowBox = visualOverflowRect(); 655 LayoutRect overflowBox = visualOverflowRect();
656 flipForWritingMode(overflowBox); 656 flipForWritingMode(overflowBox);
657 overflowBox.inflate(maximalOutlineSize(paintInfo.phase));
658 overflowBox.moveBy(adjustedPaintOffset); 657 overflowBox.moveBy(adjustedPaintOffset);
659 if (!overflowBox.intersects(paintInfo.rect)) 658 if (!overflowBox.intersects(paintInfo.rect))
660 return; 659 return;
661 } 660 }
662 661
663 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset, ForceCont entsClip); 662 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset, ForceCont entsClip);
664 paintObject(paintInfo, adjustedPaintOffset); 663 paintObject(paintInfo, adjustedPaintOffset);
665 if (pushedClip) 664 if (pushedClip)
666 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset); 665 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset);
667 } 666 }
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1458 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1457 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1459 { 1458 {
1460 ASSERT(cell->isFirstOrLastCellInRow()); 1459 ASSERT(cell->isFirstOrLastCellInRow());
1461 if (hasSameDirectionAs(cell->row())) 1460 if (hasSameDirectionAs(cell->row()))
1462 return style()->borderEnd(); 1461 return style()->borderEnd();
1463 1462
1464 return style()->borderStart(); 1463 return style()->borderStart();
1465 } 1464 }
1466 1465
1467 } 1466 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderReplica.cpp ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698