Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: Source/core/rendering/RenderTableCell.cpp

Issue 176953008: Include the outline into the visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed dumb bug caught by Mac. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableRow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1089 matching lines...) Expand 10 before | Expand all | Expand 10 after
1100 compareBorderValuesForQSort); 1100 compareBorderValuesForQSort);
1101 } 1101 }
1102 1102
1103 void RenderTableCell::paintCollapsedBorders(PaintInfo& paintInfo, const LayoutPo int& paintOffset) 1103 void RenderTableCell::paintCollapsedBorders(PaintInfo& paintInfo, const LayoutPo int& paintOffset)
1104 { 1104 {
1105 ASSERT(paintInfo.phase == PaintPhaseCollapsedTableBorders); 1105 ASSERT(paintInfo.phase == PaintPhaseCollapsedTableBorders);
1106 1106
1107 if (!paintInfo.shouldPaintWithinRoot(this) || style()->visibility() != VISIB LE) 1107 if (!paintInfo.shouldPaintWithinRoot(this) || style()->visibility() != VISIB LE)
1108 return; 1108 return;
1109 1109
1110 LayoutRect localRepaintRect = paintInfo.rect;
1111 localRepaintRect.inflate(maximalOutlineSize(paintInfo.phase));
1112
1113 LayoutRect paintRect = LayoutRect(paintOffset + location(), pixelSnappedSize ()); 1110 LayoutRect paintRect = LayoutRect(paintOffset + location(), pixelSnappedSize ());
1114 if (paintRect.y() - table()->outerBorderTop() >= localRepaintRect.maxY()) 1111 if (paintRect.y() - table()->outerBorderTop() >= paintInfo.rect.maxY())
1115 return; 1112 return;
1116 1113
1117 if (paintRect.maxY() + table()->outerBorderBottom() <= localRepaintRect.y()) 1114 if (paintRect.maxY() + table()->outerBorderBottom() <= paintInfo.rect.y())
1118 return; 1115 return;
1119 1116
1120 GraphicsContext* graphicsContext = paintInfo.context; 1117 GraphicsContext* graphicsContext = paintInfo.context;
1121 if (!table()->currentBorderValue() || graphicsContext->paintingDisabled()) 1118 if (!table()->currentBorderValue() || graphicsContext->paintingDisabled())
1122 return; 1119 return;
1123 1120
1124 const RenderStyle* styleForCellFlow = this->styleForCellFlow(); 1121 const RenderStyle* styleForCellFlow = this->styleForCellFlow();
1125 CollapsedBorderValue leftVal = cachedCollapsedLeftBorder(styleForCellFlow); 1122 CollapsedBorderValue leftVal = cachedCollapsedLeftBorder(styleForCellFlow);
1126 CollapsedBorderValue rightVal = cachedCollapsedRightBorder(styleForCellFlow) ; 1123 CollapsedBorderValue rightVal = cachedCollapsedRightBorder(styleForCellFlow) ;
1127 CollapsedBorderValue topVal = cachedCollapsedTopBorder(styleForCellFlow); 1124 CollapsedBorderValue topVal = cachedCollapsedTopBorder(styleForCellFlow);
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
1275 1272
1276 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent) 1273 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent)
1277 { 1274 {
1278 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t()); 1275 RenderTableCell* newCell = RenderTableCell::createAnonymous(&parent->documen t());
1279 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL); 1276 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL);
1280 newCell->setStyle(newStyle.release()); 1277 newCell->setStyle(newStyle.release());
1281 return newCell; 1278 return newCell;
1282 } 1279 }
1283 1280
1284 } // namespace WebCore 1281 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableRow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698