Remove V8RecrusionScope, cleanup call sites.

Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See issue 594974.

BUG=585949
Committed: https://crrev.com/8ce1943be5284c67fb79cae9bf1576624fba97b6
Cr-Commit-Position: refs/heads/master@{#381569}

[dgozman, 2016-03-07 23:00:42]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 23:00:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/1

[dgozman, 2016-03-08 00:00:12]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, pfeldman@chromium.org

[dgozman, 2016-03-08 00:00:13]

Could you please take a look? This should be a final cleanup patch.

[commit-bot: I haz the power, 2016-03-08 00:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:27:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-03-08 01:44:21]

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:343: int
cookie = m_manager->debugger()->willExecuteScript(context(),
script->GetUnboundScript()->GetId());
m_debugger->runCompiledScript?

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
(right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp:42:
v8::MicrotasksScope microtasksScope(context->GetIsolate(),
v8::MicrotasksScope::kDoNotRunMicrotasks);
We don't need microtasks around the injected scripts host / javascript source
frame.

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp (right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp:112: int
cookie = m_debugger->willExecuteScript(m_context, function->ScriptId());
m_debugger-callFunction.

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:354:
v8::MaybeLocal<v8::Value> result = script->Run(context);
ditto

[dgozman, 2016-03-08 02:23:01]

PTAL

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:343: int
cookie = m_manager->debugger()->willExecuteScript(context(),
script->GetUnboundScript()->GetId());
On 2016/03/08 01:44:20, pfeldman wrote:
> m_debugger->runCompiledScript?

Done.

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp
(right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp:42:
v8::MicrotasksScope microtasksScope(context->GetIsolate(),
v8::MicrotasksScope::kDoNotRunMicrotasks);
On 2016/03/08 01:44:20, pfeldman wrote:
> We don't need microtasks around the injected scripts host / javascript source
> frame.

Done.

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp (right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp:112: int
cookie = m_debugger->willExecuteScript(m_context, function->ScriptId());
On 2016/03/08 01:44:21, pfeldman wrote:
> m_debugger-callFunction.

Done.

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1769273004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:354:
v8::MaybeLocal<v8::Value> result = script->Run(context);
On 2016/03/08 01:44:21, pfeldman wrote:
> ditto

Done.

[dgozman, 2016-03-08 02:23:09]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 02:23:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/20001

[commit-bot: I haz the power, 2016-03-08 03:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 03:43:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nyquist, 2016-03-08 08:09:49]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2016-03-08 08:09:50]

FYI: I'm not familiar with this code, but it might be a follow up of
https://codereview.chromium.org/1743763004/ which was reverted in
https://codereview.chromium.org/1765423004/ . See https://crbug.com/592906 for
details.

[pfeldman, 2016-03-08 20:23:21]

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:329: if
(!m_manager->debugger()->client()->isExecutionAllowed())
Can you do this within runCompiledScript?

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:174:
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
Do we need this?

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:197: if
(!getScriptsFunction->Call(debuggerContext(), debuggerScript,
WTF_ARRAY_LENGTH(argv), argv).ToLocal(&value))
It seems error-prone that you manipulate two context here and need to enter one
of the and pass it into the call afterwards. Do we actually need to enter it
above?

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp:94: if
(!m_debugger->client()->isExecutionAllowed())
Move into callFunction?

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:294:
v8::Local<v8::Value> result =
host->debugger()->compileAndRunInternalScript(isolate->GetCurrentContext(),
expression);
Do we have to change the contract here? Returning Maybe was fine.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:336: if
(!host->debugger()->client()->isExecutionAllowed())
ditto

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp:48:
v8::Context::Scope contextScope(context);
Is this needed?

[dgozman, 2016-03-09 22:01:53]

PTAL

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:329: if
(!m_manager->debugger()->client()->isExecutionAllowed())
On 2016/03/08 20:23:21, pfeldman wrote:
> Can you do this within runCompiledScript?

Done.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp
(right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp:174:
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
On 2016/03/08 20:23:21, pfeldman wrote:
> Do we need this?

Yes, we do. This is a call into page context which may happen when there is no
V8 stack. We must annotate that we do not trigger microtasks here.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:197: if
(!getScriptsFunction->Call(debuggerContext(), debuggerScript,
WTF_ARRAY_LENGTH(argv), argv).ToLocal(&value))
On 2016/03/08 20:23:21, pfeldman wrote:
> It seems error-prone that you manipulate two context here and need to enter
one
> of the and pass it into the call afterwards. Do we actually need to enter it
> above?

I think we don't. Removed.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp:94: if
(!m_debugger->client()->isExecutionAllowed())
On 2016/03/08 20:23:21, pfeldman wrote:
> Move into callFunction?

Done.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:294:
v8::Local<v8::Value> result =
host->debugger()->compileAndRunInternalScript(isolate->GetCurrentContext(),
expression);
On 2016/03/08 20:23:21, pfeldman wrote:
> Do we have to change the contract here? Returning Maybe was fine.

Yeah, lost in transition. Reverted back.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:336: if
(!host->debugger()->client()->isExecutionAllowed())
On 2016/03/08 20:23:21, pfeldman wrote:
> ditto

Done.

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp (right):

https://codereview.chromium.org/1769273004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp:48:
v8::Context::Scope contextScope(context);
On 2016/03/08 20:23:21, pfeldman wrote:
> Is this needed?

Nope.

[nyquist, 2016-03-10 00:28:42]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949
==========

[nyquist, 2016-03-10 00:28:43]

nyquist@chromium.org changed reviewers:
- nyquist@chromium.org

[pfeldman, 2016-03-10 02:42:37]

lgtm

[dgozman, 2016-03-10 02:47:29]

Jochen, could you please take a look? It's mostly mechanical replace, with only
interesting file being
third_party/WebKit/Source/bindings/core/v8/Microtask.{h,cpp}.

[jochen (gone - plz use gerrit), 2016-03-10 15:47:26]

lgtm

[dgozman, 2016-03-14 18:33:43]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-14 18:33:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1769273004/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-14 18:34:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/100001

[commit-bot: I haz the power, 2016-03-14 19:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 19:03:17]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dgozman, 2016-03-14 19:12:06]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-14 19:12:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1769273004/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-14 19:12:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/120001

[commit-bot: I haz the power, 2016-03-14 20:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 20:38:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-03-14 21:14:36]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-14 21:14:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1769273004/#ps140001
(title: "new line in test")

[commit-bot: I haz the power, 2016-03-14 21:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/140001

[commit-bot: I haz the power, 2016-03-14 22:57:27]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949
==========

[commit-bot: I haz the power, 2016-03-14 22:57:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-03-14 22:58:28]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949

Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
Cr-Commit-Position: refs/heads/master@{#381103}
==========

[commit-bot: I haz the power, 2016-03-14 22:58:30]

Patchset 8 (id:??) landed as
https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
Cr-Commit-Position: refs/heads/master@{#381103}

[dvadym, 2016-03-15 14:07:35]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1804043002/ by dvadym@chromium.org.

The reason for reverting is: Speculative revert, this patch most likely to cause
browser_tests failures for Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac.

[dvadym, 2016-03-15 14:25:37]

On 2016/03/15 14:07:35, dvadym wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/1804043002/ by mailto:dvadym@chromium.org.
> 
> The reason for reverting is: Speculative revert, this patch most likely to
cause
> browser_tests failures for Linux
>
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
> Windows
>
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
> and Mac.

Revert failed, I've created a bug
https://bugs.chromium.org/p/chromium/issues/detail?id=594974 for test fixes.

[dgozman, 2016-03-15 22:14:01]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

BUG=585949

Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
Cr-Commit-Position: refs/heads/master@{#381103}
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See
issue 594974.

BUG=585949
==========

[dgozman, 2016-03-15 22:22:13]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 22:22:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/160001

[commit-bot: I haz the power, 2016-03-16 00:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 00:11:43]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-03-16 16:51:01]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 16:51:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/200001

[commit-bot: I haz the power, 2016-03-16 18:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 18:03:25]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-03-16 22:23:16]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-03-16 22:23:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1769273004/#ps200001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-16 22:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1769273004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1769273004/200001

[commit-bot: I haz the power, 2016-03-16 22:31:03]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See
issue 594974.

BUG=585949
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See
issue 594974.

BUG=585949
==========

[commit-bot: I haz the power, 2016-03-16 22:31:06]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-03-16 22:32:46]

Description was changed from

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See
issue 594974.

BUG=585949
==========

to

==========
Remove V8RecrusionScope, cleanup call sites.

- blink-side usages migrated to v8::MicrotasksScope;
- clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
- moved Microtask.{h,cpp} to bindings/core/v8;
- removed extra wrappers from V8DebuggerClient;
- fixed a couple of inspector tests which relied on trace event not emitted from
debugger anymore.

Attempt #2. First one failed due to missing scopes in platform/v8_inspector. See
issue 594974.

BUG=585949

Committed: https://crrev.com/8ce1943be5284c67fb79cae9bf1576624fba97b6
Cr-Commit-Position: refs/heads/master@{#381569}
==========

[commit-bot: I haz the power, 2016-03-16 22:32:49]

Patchset 11 (id:??) landed as
https://crrev.com/8ce1943be5284c67fb79cae9bf1576624fba97b6
Cr-Commit-Position: refs/heads/master@{#381569}