Remove V8RecrusionScope, cleanup call sites.

third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/InspectorWrapper.h"
 
 #include "platform/v8_inspector/public/V8DebuggerClient.h"
 
 #include <v8-debug.h>
 
@@ skipping 14 matching lines @@
     for (auto& config : methods) {
         v8::Local<v8::Name> v8name = v8::String::NewFromUtf8(isolate, config.name, v8::NewStringType::kInternalized).ToLocalChecked();
         v8::Local<v8::FunctionTemplate> functionTemplate = v8::FunctionTemplate::New(isolate, config.callback);
         functionTemplate->RemovePrototype();
         instanceTemplate->Set(v8name, functionTemplate, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::DontEnum | v8::ReadOnly));
     }
 
     return functionTemplate;
 }
 
-v8::Local<v8::Object> InspectorWrapperBase::createWrapper(V8DebuggerClient* client, v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context)
+v8::Local<v8::Object> InspectorWrapperBase::createWrapper(v8::Local<v8::FunctionTemplate> constructorTemplate, v8::Local<v8::Context> context)
 {
     v8::Local<v8::Function> function;
     if (!constructorTemplate->GetFunction(context).ToLocal(&function))
         return v8::Local<v8::Object>();
 
     v8::Local<v8::Object> result;
-    if (!client->instantiateObject(function).ToLocal(&result))
+    v8::MicrotasksScope microtasksScope(context->GetIsolate(), v8::MicrotasksScope::kDoNotRunMicrotasks);

[pfeldman, 2016/03/08 01:44:20]

We don't need microtasks around the injected scripts host / javascript source
frame.

[dgozman, 2016/03/08 02:23:00]

Done.

+    if (!function->NewInstance(context).ToLocal(&result))
         return v8::Local<v8::Object>();
     return result;
 }
 
 void* InspectorWrapperBase::unwrap(v8::Local<v8::Context> context, v8::Local<v8::Object> object, const char* name)
 {
     v8::Isolate* isolate = context->GetIsolate();
     ASSERT(context != v8::Debug::GetDebugContext(isolate));
 
     v8::Local<v8::Private> privateKey = v8::Private::ForApi(isolate, v8::String::NewFromUtf8(isolate, name, v8::NewStringType::kInternalized).ToLocalChecked());
 
     v8::Local<v8::Value> value;
     if (!object->GetPrivate(context, privateKey).ToLocal(&value))
         return nullptr;
     if (!value->IsExternal())
         return nullptr;
     return value.As<v8::External>()->Value();
 }
 
 v8::Local<v8::String> InspectorWrapperBase::v8InternalizedString(v8::Isolate* isolate, const char* name)
 {
     return v8::String::NewFromUtf8(isolate, name, v8::NewStringType::kInternalized).ToLocalChecked();
 }
 
 } // namespace blink