Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h" 5 #include "extensions/renderer/guest_view/extensions_guest_view_container.h"
6 6
7 #include "content/public/renderer/render_frame.h" 7 #include "content/public/renderer/render_frame.h"
8 #include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"
9 #include "ui/gfx/geometry/size.h" 8 #include "ui/gfx/geometry/size.h"
10 9
11 namespace extensions { 10 namespace extensions {
12 11
13 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer( 12 ExtensionsGuestViewContainer::ExtensionsGuestViewContainer(
14 content::RenderFrame* render_frame) 13 content::RenderFrame* render_frame)
15 : GuestViewContainer(render_frame), 14 : GuestViewContainer(render_frame),
16 element_resize_isolate_(nullptr), 15 element_resize_isolate_(nullptr),
17 weak_ptr_factory_(this) { 16 weak_ptr_factory_(this) {
18 } 17 }
(...skipping 30 matching lines...) Expand all
49 v8::Local<v8::Context> context = callback->CreationContext(); 48 v8::Local<v8::Context> context = callback->CreationContext();
50 if (context.IsEmpty()) 49 if (context.IsEmpty())
51 return; 50 return;
52 51
53 const int argc = 2; 52 const int argc = 2;
54 v8::Local<v8::Value> argv[argc] = { 53 v8::Local<v8::Value> argv[argc] = {
55 v8::Integer::New(element_resize_isolate_, new_size.width()), 54 v8::Integer::New(element_resize_isolate_, new_size.width()),
56 v8::Integer::New(element_resize_isolate_, new_size.height())}; 55 v8::Integer::New(element_resize_isolate_, new_size.height())};
57 56
58 v8::Context::Scope context_scope(context); 57 v8::Context::Scope context_scope(context);
59 blink::WebScopedMicrotaskSuppression suppression; 58 v8::MicrotasksScope microtasks(
59 element_resize_isolate_, v8::MicrotasksScope::kDoNotRunMicrotasks);
60 60
61 callback->Call(context->Global(), argc, argv); 61 callback->Call(context->Global(), argc, argv);
62 } 62 }
63 63
64 } // namespace extensions 64 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy_unittest.cc ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698