Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Microtask.h

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef Microtask_h 31 #ifndef Microtask_h
32 #define Microtask_h 32 #define Microtask_h
33 33
34 #include "bindings/core/v8/ScriptState.h"
35 #include "core/CoreExport.h" 34 #include "core/CoreExport.h"
36 #include "public/platform/WebTaskRunner.h" 35 #include "public/platform/WebTaskRunner.h"
37 #include "wtf/Allocator.h" 36 #include "wtf/Allocator.h"
38 #include "wtf/Functional.h" 37 #include "wtf/Functional.h"
39 #include "wtf/PassOwnPtr.h" 38 #include "wtf/PassOwnPtr.h"
40 #include <v8.h> 39 #include <v8.h>
41 40
42 namespace blink { 41 namespace blink {
43 42
43 // C++ calls into script contexts which are "owned" by blink (created in a
44 // process where WebKit.cpp initializes v8) must declare their type:
45 //
46 // 1. Calls into page/author script from a frame
47 // 2. Calls into page/author script from a worker
48 // 3. Calls into internal script (typically setup/teardown work)
49 //
50 // Debug-time checking of this is enforced via v8::MicrotasksScope.
51 //
52 // Calls of type (1) should generally go through ScriptController, as inspector
53 // instrumentation is needed. ScriptController allocates V8RecursionScope for yo u.
54 //
55 // Calls of type (2) should always stack-allocate a v8::MicrotasksScope(kRunMicr toasks)
56 // in the same block as the call into script.
57 //
58 // Calls of type (3) should stack allocate a v8::MicrotasksScope(kDoNotRunMicrot asks) --
59 // this skips work that is spec'd to happen at the end of the outer-most
60 // script stack frame of calls into page script:
61 // http://www.whatwg.org/specs/web-apps/current-work/#perform-a-microtask-checkp oint
44 class CORE_EXPORT Microtask { 62 class CORE_EXPORT Microtask {
45 STATIC_ONLY(Microtask); 63 STATIC_ONLY(Microtask);
46 public: 64 public:
47 static void performCheckpoint(v8::Isolate*); 65 static void performCheckpoint(v8::Isolate*);
48 66
49 // TODO(jochen): Make all microtasks pass in the ScriptState they want to be 67 // TODO(jochen): Make all microtasks pass in the ScriptState they want to be
50 // executed in. Until then, all microtasks have to keep track of their 68 // executed in. Until then, all microtasks have to keep track of their
51 // ScriptState themselves. 69 // ScriptState themselves.
52 static void enqueueMicrotask(PassOwnPtr<WebTaskRunner::Task>); 70 static void enqueueMicrotask(PassOwnPtr<WebTaskRunner::Task>);
53 static void enqueueMicrotask(PassOwnPtr<SameThreadClosure>); 71 static void enqueueMicrotask(PassOwnPtr<SameThreadClosure>);
54 }; 72 };
55 73
56 } // namespace blink 74 } // namespace blink
57 75
58 #endif // Microtask_h 76 #endif // Microtask_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698