third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 1769273004: Remove V8RecrusionScope, cleanup call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1769273004: Remove V8RecrusionScope, cleanup call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/v8.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 14eb01f1df82fa92bcc89339c471284f80b51fe8..8f3bc8dc3e11ec0cf31ed93ee8525700cef3602e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -308,6 +308,7 @@ static bool installCommandLineAPIIfNeeded(v8::Local<v8::Name> name, const Atomic

}

if (isGetter && value->IsFunction()) {

v8::Local<v8::Function> getterFunction = v8::Local<v8::Function>::Cast(value);

+ v8::MicrotasksScope microtasks(isolate, v8::MicrotasksScope::kDoNotRunMicrotasks);

if (getterFunction->Call(context, commandLineAPI, 0, nullptr).ToLocal(&value)) {

v8SetReturnValue(info, value);

return true;