Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1759323002: Revert of enforce 16byte alignment in shader contexts (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
herb_g, mtklein, f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of enforce 16byte alignment in shader contexts (patchset #1 id:1 of https://codereview.chromium.org/1759653004/ ) Reason for revert: Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86-Debug failed dm: .... FYI: loaded 23439 distinct uninteresting hashes from 23439 lines Skipping config gpu: Don't understand 'gpu'. Skipping config msaa16: Don't understand 'msaa16'. 168400 srcs * 7 sinks + 481 tests == 1179281 tasks 0ns elapsed, 5 active, 1179276 queued, 55MB RAM, 55MB peak 565 gm xfermodes2 565 gm xfermodes 565 gm xfermodeimagefilter 565 gm xfermodes3 565 gm verylarge_picture_image c:\0\build\slave\workdir\build\skia\src\core\skshader.cpp:108: fatal error: ""(0 == ((size) & 15))"" step returned non-zero exit code: 3 @@@STEP_FAILURE@@@ Original issue's description: > enforce 16byte alignment in shader contexts > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1759653004 > > Committed: https://skia.googlesource.com/skia/+/d812fb458807245daa812adb7af0733cf5b54d96 TBR=mtklein@google.com,fmalita@chromium.org,herb@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e38bcaf24b00066e167e03a5ac63cf828914d747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -83 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.h View 2 chunks +4 lines, -2 lines 0 comments Download
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkShader.h View 2 chunks +5 lines, -8 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorFilterShader.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkColorShader.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkComposeShader.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkComposeShader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkEmptyShader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/core/SkLightingShader.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPictureShader.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 2 chunks +1 line, -15 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImageShader.h View 2 chunks +1 line, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hal.canary
Created Revert of enforce 16byte alignment in shader contexts
4 years, 9 months ago (2016-03-03 22:23:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759323002/1
4 years, 9 months ago (2016-03-03 22:23:35 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 22:23:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e38bcaf24b00066e167e03a5ac63cf828914d747

Powered by Google App Engine
This is Rietveld 408576698